sunrise sunset conflict with tibble about biorad

[adokter]

@iskandari could you look into this and the suggestion by @peterdesmet of transfering to suntools?

[peterdesmet]

Not familiar with this issue, but if bioRad provides a more sensible output than suntools, than it might be good to update suntools. @adokter or @pieterh, could you look into this and potentially transfer this issue to https://github.com/adokter/suntools/issues?

[iskandari]

@grapemanJac thanks for highlighting this nuance with tibbles, which I just found out are actually just lists:

 typeof(dat)
[1] "list"

You are not able to extract a timezone using lubridate::tz() because you are passing a tibble object instead of a POSIXct object, so you have to go one level deeper:

dat <- tibble(Date = seq(as.POSIXct("2023-08-01 00:00:00",
                                    format = "%Y-%m-%d 00:00:00",
                                    tz = "Australia/Perth",
                                    force_tz = TRUE),
                         as.POSIXct("2023-08-05 00:00:00",
                                    format = "%Y-%m-%d 00:00:00",
                                    tz = "Australia/Perth",
                                    force_tz = TRUE),
                         by = '1 day'))

tz(dat[1,1])
[1] "UTC"
Warning message:
tz(): Don't know how to compute timezone for object of class tbl_df/tbl/data.frame; returning "UTC"

For example, any of these work:

tz(dat$Date)
[1] "Australia/Perth"

dat[1,1]$Date
[1] "2023-08-01 AWST"

tz(dat[1,1]$Date)
[1] "Australia/Perth"

tz(dat$Date[1])
[1] "Australia/Perth"

So this can be easily remedied in dplyr::mutate() by extracting the tz directly from the Date vector:

#Roebuck, AU

dat <- dat %>% mutate(Sunrise = bioRad::sunrise(Date, lon = 122.48, lat = -17.846, tz=tz(Date), force_tz = TRUE),
                      Sunset = bioRad::sunset(Date, lon = 122.48, lat = -17.846, tz=tz(Date), force_tz = TRUE))

dat
# A tibble: 5 × 3
  Date                Sunrise             Sunset             
  <dttm>              <dttm>              <dttm>             
1 2023-08-01 00:00:00 2023-08-01 06:19:31 2023-08-01 17:33:35
2 2023-08-02 00:00:00 2023-08-02 06:19:06 2023-08-02 17:33:52
3 2023-08-03 00:00:00 2023-08-03 06:18:40 2023-08-03 17:34:10
4 2023-08-04 00:00:00 2023-08-04 06:18:13 2023-08-04 17:34:27
5 2023-08-05 00:00:00 2023-08-05 06:17:45 2023-08-05 17:34:44