Comments (7)
@adixon-adobe You brought this component up to begin with, do you have a specific use case that you're working with? There are a couple of different ways I think we could make it "ready to ship" that leave room for further iteration via the decorator pattern or the form participation API, but what's OK depends on where this element would likely be used.
from spectrum-web-components.
@Westbrook the thing I ran into with SpectrumCSS & Spectrum it that there's no error text support (which I needed for e-mail validation errors, like "you can't invite yourself").
The form errors tutorial here shows this: https://spectrum.corp.adobe.com/page/tutorials
@lazd I think you mentioned some related work happening for other badging (and I think I offered to help back when I had time).
Anyways, I don't think that needs to come in the first round of implementation, but it's something we'll need to solve to adopt it.
from spectrum-web-components.
Now that I re-read your comment, I think we're on the same page 🥇
from spectrum-web-components.
Sorry, @adixon-adobe, I think I was unclear. I'm looking for use cases as to how the sp-textfield
will be applied in your application. In general, wrapping an <input/>
in the shadow DOM of a custom element excludes it from participating directly in parent <form/>
elements. If we're OK with manually collecting the data, via responding to change
events or querying el.value
s across any textfields, then there is less work do be done on this component before we can move forward than if we want form participation handled. The emerging specifications in https://web.dev/more-capable-form-controls are interesting, but not x-browser yet, so in that case some quality of https://medium.com/@westbrook/decorator-pattern-plus-816eefc89824 would be required to do so. With your use case being the soonest one to cover, I was hoping that knowing it could clarify the scope for the initial publication of this component in our library.
from spectrum-web-components.
Oh -- we shouldn't need to worry about <form/>
elements in our case. We've generally handled events manually (I think the only
from spectrum-web-components.
This is a SpectrumCSS issue that covers adding the error label support: adobe/spectrum-css#169
from spectrum-web-components.
Initial pass complete. We should consider additions like form participation, formData
event management, or labels in a separate issue.
from spectrum-web-components.
Related Issues (20)
- [Bug]: Click handlers on the menu-items inside of the menu do not fire correctly in IOS devices. HOT 1
- [Bug]: Spectrum Switch Not Toggling on Enter Key Press HOT 1
- [Bug]: Slider has accessibility issue when `label-visibility="none"` HOT 5
- [Bug]: dialog grid-area values distorted due to minification configs
- [Feat]: Support iPad Mini in sp-tray delivery
- [Bug]: @spectrum-web-components/contextual-help has no typings HOT 2
- [Bug]: FocusGroup won't set the tabindex=0 on the item focused using mouse HOT 1
- [Bug]: Workflow Icons and UI Icons: some attributes are missing quotation marks
- [Bug]: Picker inside dialog triggers incorrectly sized tray on iOS
- [Bug]: SWC Picker autofocus does not show focus ring when navigating via mouse
- [Bug]: dissmissable attribute on dialog hides slot=button
- [Bug]: [Ipad] Blue focus ring appear on the button after opening/closing ActionMenu component.
- [Bug]: Breadcrumbs missing lit dependency in 0.47.0
- [Bug]: Picker inside dialog registers click to items behind it on iOS
- [Bug]: OverlayTrigger can get stuck in a render loop causing page crash
- [Bug]: Required field label sometimes renders asterisk on next line
- [Bug]: Picker in iOS Safari occasionally selects item 1-2 slots above clicked item HOT 1
- [Bug]: Tabs overflow exceed tabs limit
- [Bug]: Spectrum web component: Progress Bar indeterminate does not animate on Web Views
- Optimizing bundle size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spectrum-web-components.