Coder Social home page Coder Social logo

Comments (7)

njx avatar njx commented on May 22, 2024

Hmmm. Seems like in general we should try to figure out a solution that lets the browser render independently of native modal UI. I'm a little surprised that it doesn't.

from brackets.

njx avatar njx commented on May 22, 2024

Assigning this to Glenn since it's mostly a native interaction issue.

from brackets.

peterflynn avatar peterflynn commented on May 22, 2024

Fwiw, I noticed the same thing happens with confirmation dialogs too: if you have an unsaved file open and then do File > Open, and choose Don't Save in the confirmation prompt, the confirmation prompt remains open/visible underneath the browse dialog that pops up afterward.

from brackets.

njx avatar njx commented on May 22, 2024

Reassigning to Peter to verify this bug is fixed and close it.

from brackets.

peterflynn avatar peterflynn commented on May 22, 2024

Seems like another option, long-term, would be to run the dialogs on a different thread from the browser rendering engine. Since our code has to be written to cope with modeless dialogs anyway (for the in-browser case), this shouldn't be a problem... the only issue might be if Chromium and the OS dialogs both insist on the same specific thread.

from brackets.

gruehle avatar gruehle commented on May 22, 2024

CEF, as currently written, must have all client UI on the same thread as browser UI. There is an enhancement request to make CEF support multiple UI threads, but there is no guarantee it will be done.

from brackets.

peterflynn avatar peterflynn commented on May 22, 2024

Looks good here.

To NJ's point, as soon as we start confirming unsaved changes when we switch projects (landing tomorrow?) we'll be back in a state where a native browse dialog appears right after an HTML dialog is dismissed. That said, having the background-grayout layer still be visible at that point doesn't actually feel so bad to me.

from brackets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.