Coder Social home page Coder Social logo

Missing surface_area in stats about python-admesh HOT 8 OPEN

mcorbe avatar mcorbe commented on June 24, 2024
Missing surface_area in stats

from python-admesh.

Comments (8)

hroncok avatar hroncok commented on June 24, 2024

Actually, surface area is only present in API that's not yet released. If you need it, I can do a side branch for such things, i.e. for admesh's features and changes not yet released, but I will not release that on PyPI. If you can come with a nice idea how to only put it there is it's actually present in admesh (i.e. some #ifdef Cython alternative), that would be great, such PR would be appreciated.

from python-admesh.

hroncok avatar hroncok commented on June 24, 2024

Actually looking at the code, the best approach would be to generate the ctypedefs from the header file, as it is currently done for functions.

from python-admesh.

mcorbe avatar mcorbe commented on June 24, 2024

That is what I have in mind too. Working for me on my host.

from python-admesh.

hroncok avatar hroncok commented on June 24, 2024

I don't understand, what part are you referring to?

from python-admesh.

mcorbe avatar mcorbe commented on June 24, 2024

Adding ctypedefs in the pxd file. Would that work with you too or does it have implications that I don't see ?

(Sorry for closing wrong bouton from my phone)

from python-admesh.

hroncok avatar hroncok commented on June 24, 2024

Released version of admesh dos not support surface_area. The Python admesh package (i.e. this repository) is designed to work with current (i.e. released) admesh version. If you can make it so that it would work with both released and unreleased admesh, feel free to propose a change via a pull request.

Continuous integration via Travis will check if your pull request compiles against stable admesh, some further test cases might be needed to check if it actually behaves correctly.

from python-admesh.

mcorbe avatar mcorbe commented on June 24, 2024

So, I don't have any clean solution to make it work with both released and current versions.

What is the plan with admesh releases actually ?

from python-admesh.

hroncok avatar hroncok commented on June 24, 2024

I'm currently occupied with university finals happening in two weeks. During summer I want to fix issues from this milestone https://github.com/admesh/admesh/milestones/0.99 and release 0.99. (Feel free to go trough the list an help.) When 0.99 is released, all admesh projects needs to be updated as well, including Python and Ruby bindings.

from python-admesh.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.