Android: Adjust.onResume() needs to be called before any events can be tracked about cordova_sdk

[wellle]

That sounds promising, we'll look into it.

Thanks 👍

[MaKleSoft]

Looks like you've considered my suggestion. Nice! However, I'm a little confused why you are using a cordova hook to replace strings in your javascript file rather than just injecting the values directly into the AndroidManifest.xml and *-Info.plist and reading them out in the native portion of the app. Seems like an unnecessary detour and is rather uncommon for a Cordova plugin. Again, I suggest reading the Cordova Plugin Specification for this (see link in my first comment). If you need any help with this, let me know!

[nonelse]

Hi. Thanks for the feedback.
The script for the string replace was taken from the article Three hooks your Cordova/PhoneGap project needs. Since the way we load the config values in both Android and iOS is done directly through function parameters and not file properties, we thought this was the most direct way.
We'll be happy to do it a better way if you know it. The best way would be to do a Pull Request so we could review it. The Cordova Plugin Specification is not, unfortunately, as complete or easy to use. So if you have another source of knowledge on that part, we'll be happy to consider it.
Hope that was helpful and thanks for the suggestion.

[MaKleSoft]

I think that article is targeted more towards Cordova users rather than plugin authors. The main problem with this approach is that it requires the user to manually install a git hook, which is not optimal, also, it would be nicer if parameter like the app token and log level could be managed via the config.xml rather than requiring and additional config file. Perhaps I'll take a stab at it when I have the time.