Coder Social home page Coder Social logo

Comments (6)

ashish1099 avatar ashish1099 commented on June 17, 2024 1

I will try this out and send a PR

from argo-cd-mixin.

adinhodovic avatar adinhodovic commented on June 17, 2024

Is this a HA setup with multiple replicas, where each creates an alert due to dest_server being unique?

from argo-cd-mixin.

ashish1099 avatar ashish1099 commented on June 17, 2024

@adinhodovic nope, the app name being unique creates the multiple alerts

from argo-cd-mixin.

adinhodovic avatar adinhodovic commented on June 17, 2024

@adinhodovic nope, the app name being unique creates the multiple alerts

Gotcha, think I'll not add this by default since the other alerts ArgoCdAppSyncFailed, ArgoCdAppAutoSyncDisabled are app based. Maybe a flag to toggle the behaviour off and on? A flag in config.libsonnet to toggle Alerts by app vs alerts by controller

from argo-cd-mixin.

ashish1099 avatar ashish1099 commented on June 17, 2024

yes, I saw that each alert written will endup with multiple alerts, so a toggle make sense or a maybe a record to have name labels in 1 single record and alert on that, so we get the app name (which is what the deal breaker IMHO)

from argo-cd-mixin.

adinhodovic avatar adinhodovic commented on June 17, 2024

yes, I saw that each alert written will endup with multiple alerts, so a toggle make sense or a maybe a record to have name labels in 1 single record and alert on that, so we get the app name (which is what the deal breaker IMHO)

Yeah, would be open to merging either, with a toggle to not have overlapping alerts.

from argo-cd-mixin.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.