Coder Social home page Coder Social logo

Unhandler error event about tmi HOT 9 CLOSED

addyosmani avatar addyosmani commented on June 24, 2024
Unhandler error event

from tmi.

Comments (9)

addyosmani avatar addyosmani commented on June 24, 2024

This should be fixed in master now. @igrigorik if you get a chance, could you give it another spin?

$ npm install git://github.com/addyosmani/tmi -g

from tmi.

igrigorik avatar igrigorik commented on June 24, 2024

works!

QQ, trying it on nytimes:

On Mobile:
You have more image bytes than 60% of sites
+955 kB compared to sites in the 25th percentile
+712 kB compared to sites in the 50th percentile
+198 kB compared to sites in the 75th percentile

Results are a bit confusing to me. First, it says the site is in the 60th quantile, but if so, why is +198KB for 75th percentile? That would imply that the site is 75th+ percentile.

Also, minor nitpick: KB not kB (1024 vs 1000 :)).

from tmi.

Tenzer avatar Tenzer commented on June 24, 2024

I can confirm that installing the package from master solves the problem.

from tmi.

addyosmani avatar addyosmani commented on June 24, 2024

@igrigorik It looks like my calculations were a little askew there. I'm going to pull out support for the "You have more images than N" output to the next minor release so it can properly be fixed :) For now we'll have:

$ tmi http://redrobin.com

Your image weight: 3.55 MB
Median mobile site image weight: 660 kB
Median desktop site image weight: 1.21 MB

On Mobile:
+3.49 MB compared to sites in the 25th percentile
+3.25 MB compared to sites in the 50th percentile
+2.73 MB compared to sites in the 75th percentile


On Desktop:
+3.41 MB compared to sites in the 25th percentile
+2.94 MB compared to sites in the 50th percentile
+2.14 MB compared to sites in the 75th percentile

Is that okay? The KB -> kB formatting is due to a formatting module we're using, but I'll open an upstream issue with the author to address that :)

from tmi.

inadarei avatar inadarei commented on June 24, 2024

Master works but NPM version still throws errors. Can you please re-publish? Thanks.

from tmi.

ashumeow avatar ashumeow commented on June 24, 2024

Compiler told me that 'gpagespeed' module is missing. :|
I am also having issues with NPM though 👎

from tmi.

addyosmani avatar addyosmani commented on June 24, 2024

@ashumeow is this against master or the version on npm that you're seeing that exception thrown? I'm unable to repro locally but would like to confirm before pushing a new release.

from tmi.

addyosmani avatar addyosmani commented on June 24, 2024

After a fresh clone followed by npm install && npm link on a new machine:

screen shot 2014-11-28 at 20 44 52

from tmi.

ashumeow avatar ashumeow commented on June 24, 2024

@addyosmani Yeah! You're right.

from tmi.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.