Coder Social home page Coder Social logo

Make methods treeshake-able about s HOT 3 CLOSED

adamhaile avatar adamhaile commented on June 1, 2024 1
Make methods treeshake-able

from s.

Comments (3)

adamhaile avatar adamhaile commented on June 1, 2024 1

Yeah, exactly, this is a side-effect of making the main S export a function and attaching others to it, rather than S being a module. I've gone both ways on whether that was originally a good idea or not. The main issue that has kept things the way they are is that fixing it would be a breaking change for all S code. All usages of S(() => ...) would have to switch to something like S.comp(() => ...). So far, it hasn't felt like the small size savings are worth breaking everybody's code.

from s.

luwes avatar luwes commented on June 1, 2024

Ah yes, makes sense. Might indeed not be worth it then.

from s.

marvinhagemeister avatar marvinhagemeister commented on June 1, 2024

What if we export S as the defsult export and make all others as a named one. I can make a PR if needed.

from s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.