Coder Social home page Coder Social logo

Comments (3)

adamchainz avatar adamchainz commented on July 24, 2024

Please double-check this. If I add a test to the test suite using redirect(), per the below, it passes. The browser might handle the redirect before htmx can see the response?

diff --git tests/settings.py tests/settings.py
index 0d46dc6..d80014f 100644
--- tests/settings.py
+++ tests/settings.py
@@ -14,6 +14,8 @@
 
 MIDDLEWARE: list[str] = []
 
+ROOT_URLCONF = "tests.urls"
+
 TEMPLATES = [
     {
         "BACKEND": "django.template.backends.django.DjangoTemplates",
diff --git tests/test_http.py tests/test_http.py
index 14707ec..3448727 100644
--- tests/test_http.py
+++ tests/test_http.py
@@ -7,6 +7,7 @@
 from django.core.serializers.json import DjangoJSONEncoder
 from django.http import HttpResponse
 from django.http import StreamingHttpResponse
+from django.shortcuts import redirect
 from django.test import SimpleTestCase
 
 from django_htmx.http import HttpResponseClientRedirect
@@ -162,6 +163,18 @@ def test_success(self):
             response["HX-Trigger"] == '{"showConfetti": {"colours": ["purple", "red"]}}'
         )
 
+    def test_success_redirect(self):
+        response = redirect("/")
+
+        result = trigger_client_event(
+            response, "showConfetti", {"colours": ["purple", "red"]}
+        )
+
+        assert result is response
+        assert (
+            response["HX-Trigger"] == '{"showConfetti": {"colours": ["purple", "red"]}}'
+        )
+
     def test_success_no_params(self):
         response = HttpResponse()
 
diff --git tests/urls.py tests/urls.py
new file mode 100644
index 0000000..637600f
--- /dev/null
+++ tests/urls.py
@@ -0,0 +1 @@
+urlpatterns = []

from django-htmx.

quackerex avatar quackerex commented on July 24, 2024

The browser might handle the redirect before htmx can see the response?

I've tested with Safari and Chrome and this might be the case.

from django-htmx.

adamchainz avatar adamchainz commented on July 24, 2024

Alright then, nothing we can do here.

from django-htmx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.