Comments (7)
Yeah, I think there is. It will help identify missing things and make it easier to add typing to supported libraries.
from adafruit_python_platformdetect.
Sounds good! I'll get on it.
from adafruit_python_platformdetect.
I'm having some issues with cyclic imports and the best way to solve it I think would probably be to flatten board.py
and chip.py
into __init__.py
. Wanted to check in about doing so before actually submitting a PR with that change, since it's a pretty decent structural change. Basically the problem is that I can't type the other two files' classes as taking Detector
as an argument based on the current structure, and wanted to weigh that change against the benefit of typing
from adafruit_python_platformdetect.
Any thoughts on this? I know it would be a somewhat large change, at least in terms of organization of code. If it makes sense not to rearrange, it may warrant just closing this issue.
from adafruit_python_platformdetect.
The cyclic import issues may actually mean that the imports might need slight updating. Please don't flatten the files. That will break Blinka until it is updated there too and we recently went through a sizable bump when they were unflattened about a year ago and I'd prefer not to do that.
from adafruit_python_platformdetect.
If it's giving you trouble, I can go through and update... Just not today. I just redid all the Blinka Displayio stuff and that was way more complex than this. I think I also bumped into the cyclic import issue with that and just fixed it so it wasn't cyclically importing.
from adafruit_python_platformdetect.
Sounds good!
from adafruit_python_platformdetect.
Related Issues (20)
- Adafruit Blinka fails to detect Orange Pi Zero 2 correctly HOT 5
- Pi4B not recognized HOT 3
- CM4001032 Not Recognized HOT 2
- Libre AML-S905X-CC (LePotato) HOT 6
- Raspberry pi 4B 8GB d03115 not detected HOT 1
- Add any_embedded_linux test to detect.py HOT 1
- Simplify Pi 4 (and possibly CM4) Rev Code Checks HOT 3
- Unable to install but it was working previously HOT 11
- Move from setup.py to pyproject.toml
- Build fails HOT 3
- Problem for Orange Pi zeros 2 detection on Debian HOT 11
- Problem with Detecting A new version of Raspberry pi 3B + HOT 5
- Build failures due to board.py exceeding maximum lines permitted by Pylint HOT 2
- Circuitpython - Generic datalogger code using platformdetect for sbc/embedded library switching HOT 2
- Recursion Error when recognizing on certain systems HOT 10
- Unsupported Board (d03115) HOT 4
- #331 breaks microcontroller package HOT 4
- OLIMEX_LIME2 Not Found HOT 1
- circuitpython-build-bundles causing CI failures HOT 3
- detector.chip.id raise AttributeError() # Avoid infinite recursion on RPI 3 B HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adafruit_python_platformdetect.