Coder Social home page Coder Social logo

Comments (7)

makermelissa avatar makermelissa commented on July 17, 2024

Yeah, I think there is. It will help identify missing things and make it easier to add typing to supported libraries.

from adafruit_python_platformdetect.

tekktrik avatar tekktrik commented on July 17, 2024

Sounds good! I'll get on it.

from adafruit_python_platformdetect.

tekktrik avatar tekktrik commented on July 17, 2024

I'm having some issues with cyclic imports and the best way to solve it I think would probably be to flatten board.py and chip.py into __init__.py. Wanted to check in about doing so before actually submitting a PR with that change, since it's a pretty decent structural change. Basically the problem is that I can't type the other two files' classes as taking Detector as an argument based on the current structure, and wanted to weigh that change against the benefit of typing

from adafruit_python_platformdetect.

tekktrik avatar tekktrik commented on July 17, 2024

Any thoughts on this? I know it would be a somewhat large change, at least in terms of organization of code. If it makes sense not to rearrange, it may warrant just closing this issue.

from adafruit_python_platformdetect.

makermelissa avatar makermelissa commented on July 17, 2024

The cyclic import issues may actually mean that the imports might need slight updating. Please don't flatten the files. That will break Blinka until it is updated there too and we recently went through a sizable bump when they were unflattened about a year ago and I'd prefer not to do that.

from adafruit_python_platformdetect.

makermelissa avatar makermelissa commented on July 17, 2024

If it's giving you trouble, I can go through and update... Just not today. I just redid all the Blinka Displayio stuff and that was way more complex than this. I think I also bumped into the cyclic import issue with that and just fixed it so it wasn't cyclically importing.

from adafruit_python_platformdetect.

tekktrik avatar tekktrik commented on July 17, 2024

Sounds good!

from adafruit_python_platformdetect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.