Coder Social home page Coder Social logo

Comments (7)

infokiller avatar infokiller commented on July 16, 2024 2

Thanks @ErikBjare for the quick fix!

from aw-watcher-vim.

johan-bjareholt avatar johan-bjareholt commented on July 16, 2024 1

I think this is important, syncronous commands can be quite slow. aw-watcher-vim already did shell commands prior to this change, but they did so asyncronously, so it did not have an impact on responsiveness. There is nothing more annoying than an unresponsive editor!

I think that the branch detection should be made asyncronous as well. It's also a bit excessive to check git branch on pretty much every time you move the cursor.

from aw-watcher-vim.

infokiller avatar infokiller commented on July 16, 2024 1

I can confirm this makes editing in vim totally unusable.
@johan-bjareholt @FilipHarald I think this change should be reverted until there's a more efficient async implementation working.

from aw-watcher-vim.

vonPB avatar vonPB commented on July 16, 2024

Totally agree with you @johan-bjareholt. It would be sufficient to get the branch on buffer change for instance and save it as a global variable instead.

from aw-watcher-vim.

johan-bjareholt avatar johan-bjareholt commented on July 16, 2024

Maybe just checking every 10-60seconds (possibly configurable) and do it asynchronously would probably be good. Should be a bit more reliable than a buffer change.

from aw-watcher-vim.

FilipHarald avatar FilipHarald commented on July 16, 2024

Ah, my bad. I can look into it this weekend. But I can't promise I'll solve it :)

from aw-watcher-vim.

ErikBjare avatar ErikBjare commented on July 16, 2024

@infokiller I agree, it was my bad to merge too eagerly. Reverted now, see #25 (comment)

from aw-watcher-vim.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.