Should postmark's api key be set in an initializer file? about postmark-rails

[zmillman]

I'm successfully using the following code in an initializer config/initializers/postmark.rb

# Configures Postmark with API settings

ActionMailer::Base.postmark_settings = {
  :api_key => 'api-key-goes-here'
}

[temochka]

In most cases Postmark is only used to deliver emails in production environment. If there is a staging or QA environment, then per-environment settings are required. This is why it’s recommended to use application.rb and its successors production.rb, development.rb, etc.

Of course, you still can use an initializer. This is all up to you. I don’t see a problem here. This is worth mentioning in the docs though. Thanks!

[zmillman]

The rails style guide recommends putting gem-specific configuration in the initializers folder: https://github.com/bbatsov/rails-style-guide#configuration

In the rails default configuration, delivery_method is set independently in each environment file so it seems confusing to set the production value in application.rb and override it in development/test instead of just setting it to :postmark in production.rb

I can write a pull request if you think this is a good change :)