Comment api endpoint broken about github-script

[aulneau]

@jclem ah, perfect, that was the issue. Didn't realize that conflicts affected things in such a way, good to know! I appreciate your help!

[jclem]

Hey @aulneau thank you for reporting this! This issue should be opened against the octokit/rest.js repository. I don't maintain that project, it's just a dependency of this action 😄

[aulneau]

Hi there @jclem, it seems as though this is not an issue in the octokit/rest repo, but an issue with the context object not containing the data it should. Do you know why it might not contain an issue number? you can see the log of context here https://github.com/blockstack/docs.blockstack/runs/878974240?check_suite_focus=true

[jclem]

@aulneau Ah, I see what's happening now! Sorry for the misdirection. This workflow is running on push as well as pull_request. The push event won't have information about any pull request in it, so the number isn't present. The pull_request workflow will run when the pull request branch is synced to, so there's no need for push, unless you have it there for some other reason.

Let me know if that helps!

[aulneau]

hmm I see -- I added push because when I added anything to the pull request, the action would not fire.

[jclem]

Hey @aulneau in this case, I believe that is due to the merge conflict on stacks-network/docs#655. When there's a merge conflict on a PR, there's not merge commit, which is the SHA that Actions uses to run the workflow from. If we just ran on the head of the PR branch itself, for example, the workflow wouldn't represent the state of the PR if it were merged at that point.

[bernhardkaindl]

I got the same error with a correct URL. In my case the cause was that self-hosted github-runners need to get explicit permission in the .github/workflows/yourfile.yaml:

permissions:
  pull-requests: write  # Needed for creating comments in pull-requests thru the API
  statuses: write  # Needed in case the github action wants to set the commit pending state