Coder Social home page Coder Social logo

use quiet about checkout HOT 19 CLOSED

actions avatar actions commented on June 15, 2024 20
use quiet

from checkout.

Comments (19)

timotheecour avatar timotheecour commented on June 15, 2024 13

group doesn't help much if you're reading raw logs... can we please have --quiet option?

from checkout.

Allon-Guralnek avatar Allon-Guralnek commented on June 15, 2024 6

The amount of logs this generates is insane. Please consider at least giving us the option to quiet it down.

from checkout.

froger-me avatar froger-me commented on June 15, 2024 5

Please reopen

from checkout.

kokosing avatar kokosing commented on June 15, 2024 3

For big project like https://github.com/trinodb/trino where we have plenty of jobs (currently 35) we we run very often (like 40 times per day). We are pretty sure that is working just fine as it has never failed for us (at least I don't recall a case), but still every single log file has about 170 lines with git progress that does not add any value. We usually read the raw log file as UI is not responsive with such huge log files (browser is not much responsive too but it is a bit better with raw files).

Maybe we could have debug option to troubleshoot problems with there are issues with checkout instead? And have --quite to be used by default?

from checkout.

FernandoMiguel avatar FernandoMiguel commented on June 15, 2024 2

This is what I get for half reading comments while having breakfast.
Cheers

from checkout.

wipe2238 avatar wipe2238 commented on June 15, 2024 1

When you watch the workflow running, you won't feel the git fetch is hanging.

Problem is, Actions tab really have problems with handling long and quickly updating steps, up to the point that it's freezing browser while action is running. That's UI issue, not anything wrong with action itself, but actions/checkout is usually running early, and is used in most workflows around.
So i can't watch workflow running anyway, unless i open tab only after checkout finishes and live log is hidden :/

TL;DR i'd like having quiet here, just to have live preview actually working; frontend team failed to deliver, so maybe backend team can make it happen ;)

from checkout.

simonbaird avatar simonbaird commented on June 15, 2024 1

FYI I think I have a good solution for this, see #1067 .

from checkout.

TingluoHuang avatar TingluoHuang commented on June 15, 2024

We can provide an option to turn on --quite
There are 2 reasons we have --progress

  • When you watch the workflow running, you won't feel the git fetch is hanging.
  • When you try to investigate why my checkout action is slow, the progress output can give some idea about how many objects you are fetching and what's the average object download speed.

from checkout.

FernandoMiguel avatar FernandoMiguel commented on June 15, 2024

Didn't know the command option was available.
Maybe add it to the docs?
Thanks

from checkout.

TingluoHuang avatar TingluoHuang commented on June 15, 2024

@FernandoMiguel we don't have it right now, we can consider adding it. 😄

from checkout.

FernandoMiguel avatar FernandoMiguel commented on June 15, 2024

The docs or the flag? 🤔

from checkout.

TingluoHuang avatar TingluoHuang commented on June 15, 2024

the flag. 😄

from checkout.

FernandoMiguel avatar FernandoMiguel commented on June 15, 2024

Damn it...
That explains why my build failed lol
Git revert Ahah

from checkout.

moltar avatar moltar commented on June 15, 2024

Agree with OP, the log seems to be quite verbose:


Receiving objects:   6% (19/304)

                                                                                
Receiving objects:   7% (22/304)

                                                                                
Receiving objects:   8% (25/304)

                                                                                
Receiving objects:   9% (28/304)

                                                                                
Receiving objects:  10% (31/304)

                                                                                
Receiving objects:  11% (34/304)

                                                                                
Receiving objects:  12% (37/304)

                                                                                
Receiving objects:  13% (40/304)

                                                                                
Receiving objects:  14% (43/304)

                                                                                
Receiving objects:  15% (46/304)

But I can also see it being useful.

I wish there was a way to disable that though. I am not really watching checkout ever.

from checkout.

ericsciple avatar ericsciple commented on June 15, 2024

Marking as enhancement and I'll defer to others.

Personally, +1 what @TingluoHuang said. Sense of motion and timestamps are good for us to help customers. I'm generally hesitant to add extra inputs (overload user with options).

from checkout.

sauyon avatar sauyon commented on June 15, 2024

I feel like the real solution here would be to add support for the carriage return clearing the line.

from checkout.

ericsciple avatar ericsciple commented on June 15, 2024

Output from the step is now grouped so that should help.

from checkout.

grosser avatar grosser commented on June 15, 2024

@ericsciple plz reopen, it's still wasteful/unhelpful to have all these extra log lines
quiet as default and a flag to undo would be great

from checkout.

rgoliveira avatar rgoliveira commented on June 15, 2024

Just to add another POV: depending on how many jobs/runs and the nature of them, a repo can quickly use large amounts of storage space to accommodate these logs. I fail to see how the proposed flag could be a problem.

from checkout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.