Outdated model link about cicero-template-library

[mttrbrts]

@Aniruddha-Shriwant Where are the Model Dependencies generated?

The nunjucks template generates the output based on data from the API.

[arshadkazmi42]

I was looking into this bug and found the code here,
https://github.com/accordproject/cicero-template-library/blob/master/run.js#L389
which is getting rendered in the template.
This is the value getting rendered template.getTemplateModel().getModelFile().getExternalImports()
so I am thinking of a fix to use regex to find versions in url v2.0/ and then formatting it to 0.2.0 and replacing .cto with @0.2.0.cto

Is this the expected fix for this? Or it can be achieved by some other way?

[irmerk]

@dselman @jeromesimeon @mttrbrts I'm not as familiar with nunjucks so I will defer to you all and help if I can.

[Aniruddha-Shriwant]

@irmerk Can I work on this?

[Aniruddha-Shriwant]

@irmerk as the issue was old... at that time latedeliveryandpenalty template would be having version 0.13.1 as latest but now it is 0.16.0 so in ./build/ should I change both the versions or just the latest...?

[Aniruddha-Shriwant]

@irmerk, not just latedeliveryandpenalty but all those templates which have org.accordproject.time.* in their model dependencies have outdated link...
Here is that list
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"
"https://templates.accordproject.org/[email protected]"

Steps to reproduce the behavior:

1. Go to any of the above links
2. Click on org.accordproject.time.* in the model dependencies
3. See error

[irmerk]

I think other people are going to be more of a help here, see #245 (comment)

[Aniruddha-Shriwant]

So, @dselman @jeromesimeon @mttrbrts can any of you throw some light on this?

[Aniruddha-Shriwant]

@Aniruddha-Shriwant Where are the Model Dependencies generated?

The nunjucks template generates the output based on data from the API.

Thanks for pointing out that, I was looking for Model Dependencies in run.js 🤦‍♂️

[Aniruddha-Shriwant]

I had fixed the bug
by replacing this line :
<li><a href="{{uri | replace(".cto", ".html")}}">{{ns}}</a></li>
with this
<li><a href="{{uri | replace("v2.0/time", "[email protected]") | replace(".cto", ".html")}}">{{ns}}</a></li>

But when I run npm run build and opens some HTML files which were having the bug, I noticed that the bug is still present in them.
Hence for testing purpose I incremented their version from package.json and then run the npm run build command again, as the new files for that particular template are generated, by opening those files in browser I noticed that the bug was resolved...

So my question is should I increment the template version which are having the bug (I had already listed which templates are having the bug here) Or is there any other solution for that?

[Aniruddha-Shriwant]

@mttrbrts, can you suggest what I can do about this? This is similar to this(but this was fixed afterward...)
I will create a PR for this and then we can look into its preview build...

[Aniruddha-Shriwant]

@mttrbrts, I had created a PR you may see in the preview build that the bug was not fixed...

[Aniruddha-Shriwant]

Taking this discussion to #385