Coder Social home page Coder Social logo

Comments (3)

xavierleroy avatar xavierleroy commented on August 26, 2024

The only reason for using fld/fsd (64-bit FP loads and stores) in memcpy is that it transfers 8 bytes in one instruction even if we're on a RISC-V 32-bit machine, which lacks the ld/sd instructions But you're right that on a 64-bit RISC-V, ld/sd works just as well.

Also, the PowerPC and x86 ports avoid generating FP instructions for memcpy if the -fno-fpu flag is given. The RISC-V port should also honor this flag. I'll look into this shortly.

from compcert.

xavierleroy avatar xavierleroy commented on August 26, 2024

This should be fixed by 35feefd . For 64-bit RISC-V, memcpy now uses X31, like in your patch. For 32-bit RISC-V, a FP register is used unless -fno-fpu is given, in which case the copy is done through X31 by chunks of at most 32 bits.

from compcert.

xxuejie avatar xxuejie commented on August 26, 2024

Thank you for the super fast fix! I totally neglected the 32 bit case :) The change deployed to address the issue here is perfect.

from compcert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.