Comments (6)
I think we can also provide better errors as there is a mapping on the native side: https://developer.apple.com/documentation/authenticationservices/asauthorizationerror/code
from dart_packages.
@tp After looking more at the whole error handling of the authorization, maybe it also makes sense to only support a single request per authorization on the Dart side.
My reasoning behind this: I didn't find a way of providing both Password and an Apple ID request where I wouldn't run into an error in case no password is stored.
from dart_packages.
My reasoning behind this: I didn't find a way of providing both Password and an Apple ID request where I wouldn't run into an error in case no password is stored.
We can definitely simplify this on the native side (to only allow requesting 1 at a time), so get more logic on the Dart side. I would still allow the consumer to request a list of authentications with a priority/order, so that the usage is very simple.
from dart_packages.
@tp With the improved API, I think we can close this.
from dart_packages.
@HenriBeck I still think it has 1 ugliness by throwing for a missing Keychain entry instead of returning null
. But will verify and attempt a fix for that later. Consumers should definitely execute each login attempt in an individual try/catch.
from dart_packages.
@tp I think throwing an error is more appropriate here, to be honest. I would consider this a success flow, and as you said, the user should wrap each call in a try/catch
.
So I think it's easier to throw an error and not have to handle the null
case in the success flow (even with NNDB coming up)
from dart_packages.
Related Issues (20)
- [SIGN_IN_WITH_APPLE]"Cannot Complete Request" Error after Clicking "Continue", Flutter Web HOT 1
- <data> tag failed HOT 3
- SSO with Apple in Flutter web not working
- SSO Apple sing in with firebase show Error Continue button not working , Flutter Web
- Apple delete account HOT 1
- sign_in_with_apple ^5.0.0 is forbidden HOT 1
- sign_in_with_apple: Migrate to `package:web` to support WASM HOT 6
- sign_in_with_apple: getCredentialState always returns authorized HOT 3
- Fix deprecation warnings
- Update dependencies (js) in sign_in_with_apple_web HOT 1
- iOS - Apple login not getting correct email and after successful login nothing happens HOT 2
- sign_in_with_apple web: TypeError when the sign in flow completes in version 6.0.0, works in 5.0.0 HOT 7
- I hope to add an option to remove Android dependencies, as Apple login is generally not needed on Android devices. HOT 4
- Add iOS privacy manifests HOT 4
- [sign_in_with_apple] Add privacy manifest file for iOS HOT 1
- Cannot find symbol ... sign_in_with_apple.SignInWithApplePlugin() HOT 6
- Facing issue in getting name in apple signin. HOT 9
- The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher. HOT 6
- userIdentifier is null on web HOT 4
- Remove references to deprecated v1 Android embedding HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart_packages.