virtnbdbackup: redefining checkpoints failes about virtnbdbackup

[skleijkers]

Hi,

I think I found the problem. The function needs three arguments and it only gets two.
virDomainCheckpointPtr virDomainCheckpointCreateXML (virDomainPtr domain,
const char * xmlDesc,
unsigned int flags)
and in libvirthelper.py on line 438 it is called with two arguments:
domObj.checkpointCreateXML(
checkpointConfig, libvirt.VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE
)

[abbbi]

check fix in in branch issue_40:

2182c99

and tell me if it fixes the situation: im not using the redefine functionality at all and it was added on request
by another person, ..

[skleijkers]

Works like a charm! Thx.

I only have to test the --checkpointdir option. For a inc and diff backup it isn't necessary, because with those types you are using the directory of the previous full or inc backup and there is also the right checkpoint directory with all the right checkpoints (so the option is not needed and I didn't define it in my test, because I saw in the code it always tries to redefine if there are no checkpoints). But if migrate a machine and you want to make a full backup you need to redefine the previous checkpoints from the previous backup directory, else you get the error the virtnbdbackup.0 checkpoint can't be defined (or deleted, because it doesn't exist), because the bitmap with the virtnbdbackup.0 reference already exists. So for the full you first have to define the old checkpoints, then you can delete them and make a new one.