AttributeError: 'NoneType' object has no attribute 'dfas' about resholve

[D3vil0p3r]

I applied the suggested workaround and then I get a long output containing something like:

(command.CommandList
  children: [
    (command.ShAssignment
      left: <Id.Lit_VarLike 'QUERIES='>
      pairs: [
        (AssignPair
          left: <Id.Lit_VarLike 'QUERIES='>
          lhs: (sh_lhs_expr.Name left:<Id.Lit_VarLike 'QUERIES='> name:QUERIES)
          op: assign_op.Equal
          rhs: {<50>}
        )
      ]
      redirects: []
    )
    (command.ShAssignment
      left: <Id.Lit_VarLike 'DOMAIN='>
      pairs: [
        (AssignPair
          left: <Id.Lit_VarLike 'DOMAIN='>
          lhs: (sh_lhs_expr.Name left:<Id.Lit_VarLike 'DOMAIN='> name:DOMAIN)
          op: assign_op.Equal
          rhs: {($ Id.VSub_Number 1)}
        )
      ]
      redirects: []
    )
    ....
    ```
    but when I run again `resholve ./lbd --interpreter none --path ""`, I still get the error of the first post.

[abathur]

Ok. The long output is just a parse tree (good sign), so maybe there's an actual fix we'll need.

I'll take a look at updating the version resholve uses. Sometimes these are quick and trivial, and sometimes they mean a bit of testing and refactoring. Won't know about timeline until I get my hands dirty.

[abathur]

I'm not sure I'll have access to a computer today to poke at this, but if you have a little time a good place to start is with seeing if oil's osh shell can parse it.

You can just try the one in nixpkgs. I think maybe like nix-shell -p oil --command "osh -n lbd" might work.

If that works, it's possible this is something oil's alresdy caught and fixed in the meantime. If not, we may need to figure out where it's going awry in order to check upstream for a matching issue or open our own. (if there's already one open, it may also have a recommended workaround and some notes on whether this is a quick fix or not.)

[D3vil0p3r]

The output of that command is:

   if [ $[ $D1 * 3600 + $D2 * 60 + $D3 ] -lt $D4 ]
           ^~~
lbd:78: In expressions, remove $ and use `D1`, or sometimes "$D1"

[abathur]

Sounds like maybe its a wontfix parse issue with a preferred workaround that is now being correctly caught/messaged in newer osh versions.

Can you try to get that workaround working against osh and then see if it'll run through resholve?

[abathur]

I did take a swing at updating from 0.14.x to 0.15.x this past weekend, but this update isn't trivial. Upstream has refactored how exceptions work, and resholve reuses that behavior to get ~free location indicators on its exceptions--I'll need to take a little time to understand what's changed and how to track it.

[abathur]

I think I have updates to 0.20.0 worked out and pushed to https://github.com/abathur/resholve/tree/update_oil (current head: 05b25ce).

Can you confirm whether this works on your script?