Coder Social home page Coder Social logo

Comments (2)

kyzia551 avatar kyzia551 commented on June 2, 2024

Hello @sakulstra !

Thank you very much for research. I will remove this "d" letter soon.

The issue is related to that I used a common interface for the most part of the pool operations, which is not allowing to use same id for different entities compatible with this interface

Is it matter for you to have direct access to pool interactions by txHash? Because the main problem is that it could be more than 1 deposit in the same tx, and I'm thinking about how to make this id unique and easily accessable for end users. Is the idea with numbers after txHash like
id: txHash + 0..9 will fit for you?

from aave-protocol.

sakulstra avatar sakulstra commented on June 2, 2024

@kyzia551 I just noticed it when trying to link the deposit transactions on aavewatch.now.sh to the corresponding etherscan transaction.

While this would work for me, i'd prefer having id as sth unique (I don't really care to much how it is constructed- but i guess 0..9 would fall short when more than 9 deposits are done in a single transaction?), but also having the tx as part of the payload.

id: ID! # some unique id
tx: ID! # not necessarily unique tx hash

from aave-protocol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.