Coder Social home page Coder Social logo

Comments (4)

connorshea avatar connorshea commented on June 9, 2024

You can also see something similar happen in bundler.rbi where class RGProxy < ::Gem::SilentUI becomes class RGProxy < SilentUI, causing an Sorbet error.

from sord.

AaronC81 avatar AaronC81 commented on June 9, 2024

Changing name to path in https://github.com/AaronC81/sord/blob/master/lib/sord/rbi_generator.rb#L68-L73 produces this result instead:

class ListCommand < LibraryCommand
  include YARD::Templates::Helpers::BaseHelper
  # ...
end

This is probably better than the current behaviour, but still not identical to the original include.

from sord.

connorshea avatar connorshea commented on June 9, 2024

With that change (after #90), it goes from 209 errors to 175 in sord_examples.

from sord.

connorshea avatar connorshea commented on June 9, 2024

Here's a related test:

it 'returns fully qualified classes' do
  YARD.parse_string(<<-RUBY)
    class Alphabet
    end

    class Letters < Alphabet
    end

    class A < Alphabet::Letters
      # @return [void]
      def x; end
    end
  RUBY

  expect(subject.generate.strip).to eq fix_heredoc(<<-RUBY)
    # typed: strong
    class Alphabet
    end
    
    class Letters < Alphabet
    end
    
    class A < Alphabet::Letters
      sig { void }
      def x; end
    end
  RUBY
end

from sord.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.