Comments (2)
opcode81
commented on June 26, 2024
The class SpanningTree doesn't do a whole lot and what it does is unlikely to be a useful abstraction in general. YAGNI, I daresay. I therefore propose that it be merged with its subclass. Generalising it would, accordingly, not be a good idea in my opinion. (Why was this class created in the first place?)
We could think about moving the Delaunay graph function outside of the geoanalytics package if it is ever needed in another context, but this really isn't a TODO item that should be tracked. I thus propose to close this issue.
from sensai.
opcode81
commented on June 26, 2024
Closing this issue as there was no objection.
from sensai.
Related Issues (20)
- Notebook Test Failure: PyTorch-Lightning ImportError HOT 2
- Rule-Based Models' fit interface
- Notebook test failure due to TypeError in nbconvert HOT 1
- Simplify/improve naming of evaluator/evaluation utility classes HOT 1
- Add tests for evaluation util classes
- Add tests for regression models HOT 1
- Add backwards compatibility tests from v0 to v1 HOT 1
- Update notebooks to v1 and re-enable them for the docs build
- Parallelize ModelEvaluation.compare_models HOT 1
- Expose default eval metrics to user
- More explicit log and progress bar in ModelEvaluation.compare_models HOT 1
- Add to_feature_generator to ColumnGenerator HOT 1
- "Vectorize" ColumnGeneratorCachedByIndex HOT 2
- Add InMemoryPersistentKeyValueCache HOT 2
- Support pandas 2 HOT 1
- support test_io_data_dict in MultiDataModelEvaluation
- FeatureGenerators: Support normalisation alongside categorical features that are not encoded
- cloudpickle dependency
- "There are 14 competing standards"
- Add support for MPS backend HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sensai.