Coder Social home page Coder Social logo

Comments (10)

a-tokyo avatar a-tokyo commented on August 21, 2024 1

@sidan5 Check version 1.7.3 -- Are you still facing the problem.

from apple-signin-auth.

a-tokyo avatar a-tokyo commented on August 21, 2024 1

@sidan5 I think @zicyApp's answer solved this issue. Please reopen the issue if you're still facing this problem.

@zicyApp Thanks for your contributions!

from apple-signin-auth.

sidan5 avatar sidan5 commented on August 21, 2024

@zicyApp Can you look into this?

from apple-signin-auth.

zicyApp avatar zicyApp commented on August 21, 2024

@sidan5 I think it should be await appleSignin.revokeAuthorizationToken(refreshToken, options);

from apple-signin-auth.

sidan5 avatar sidan5 commented on August 21, 2024

@sidan5 I think it should be await appleSignin.revokeAuthorizationToken(refreshToken, options);

It's not recognized as asynchronous function...

from apple-signin-auth.

zicyApp avatar zicyApp commented on August 21, 2024

@sidan5 also the revoke should only return an empty 200 on success

from apple-signin-auth.

sidan5 avatar sidan5 commented on August 21, 2024

@a-tokyo Still get no error and an empty response for any dummy token. Expect to get some error response.

from apple-signin-auth.

zicyApp avatar zicyApp commented on August 21, 2024

@sidan5 @a-tokyo I've done some extra tests with the revoke call.

We can only get { error: 'invalid_client' } when the client_id or the client_secret is invalid. With a dummy/expired token you can only get an empty response.

I also had a typo in the last parameter token_type_hint, but it's optional so the call should work without that anyway.

from apple-signin-auth.

sidan5 avatar sidan5 commented on August 21, 2024

@zicyApp so how do you know when success? 🤔

from apple-signin-auth.

zicyApp avatar zicyApp commented on August 21, 2024

@sidan5 I test it normally with the complete login flow

  • Login with apple in your app
  • Save access/refresh token
  • Login to https://appleid.apple.com/ to make sure you the authorized app is on the list
  • Call revoke with the valid credentials
  • On https://appleid.apple.com/ the previously authorized app should not be there anymore

from apple-signin-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.