Comments (9)
Thanks for reporting, I will check this ASAP
from min.
I am sorry, but I'm unable to reconstruct this issue. Tested in TYPO3 11 with PHP 8 and TYPO3 10 with PHP 7.4.
Also with invalid regular expressions, I don't get your result.
Can you give me more info and dump your plugin.tx_min config?
from min.
@a-r-m-i-n Thanks for checking. I've tested on Typo3 10.4.16 / PHP 7.4 and additional config like this:
plugin.tx_min.tinysource {
head {
protectCode {
10 = /(<script.*?>.*?<\/script>)/is
}
}
body {
protectCode {
10 = /(<script.*?>.*?<\/script>)/is
}
}
}
from min.
Hello,
we do have the same behavior. Textareas will be replaced with #!#protected_XXX#!#. The XXX is a hash and regenerates with every refresh.
We use the latest T3 10 LTS with PHP 7.4 and the following configuration:
plugin.tx_min.tinysource {
enable = 1
head {
stripTabs = 1
stripNewLines = 1
stripDoubleSpaces = 1
stripTwoLinesToOne = 1
stripSpacesBetweenTags = 0
}
body {
stripComments = 1
stripTabs = 1
stripNewLines = 1
stripDoubleSpaces = 1
stripSpacesBetweenTags = 0
stripTwoLinesToOne = 0
preventStripOfSearchComment = 1
protectCode {
10 = /(<textarea.*?>.*?<\/textarea>)/is
20 = /(<pre.*?>.*?<\/pre>)/is
}
}
oneLineMode = 1
}
config {
compressCss = 1
concatenateCss = 1
compressJs = 1
concatenateJs = 1
}
The static template of min 2.0.0 is not included.
from min.
Okay thanks. Locally I'm still not able to reconstruct this issue, but on my own website's dev environment, I was able to reconstruct.
I'm going to fix it as soon as possible.
from min.
Okay, I see the problem.
I've moved the "protectCode" to the root level of tinysource configuration. In your code, it is still located within head and body.
This was a major upgrade, which breaks old configurations, which is also well documented:
https://docs.typo3.org/p/t3/min/2.0/en-us/Configuration.html#html-source-compression
from min.
I reopen this issue, because I want to fix this behaviour.
If you provide inconsistent config, this should not be the result.
The reason why this is happening: At the place where the protection applies, the body version of protectCode is defined as fallback, in case the root version is missing.
But when restoring the protected code, this fallback is missing.
I'm going to replace the fallback at all. In worst case, you will get no protected textareas, then.
Also I want to improve documentation, when upgrading from v1.
from min.
Thank you!
from min.
Thank you. With changing the configuration, min works like a charm.
from min.
Related Issues (19)
- Compression of AssetCollector Assets HOT 3
- Old versions no longer downloadable HOT 5
- PHP Warning: Undefined array key "debug"
- why use ext_typoscript_setup.txt for enable = 1 HOT 2
- Possible error in ext_localconf.php? HOT 1
- Relative CSS paths are wrong HOT 7
- Support composer-installer-v4 HOT 5
- Option to disable compression for single asset HOT 3
- Undefined array key "priority"
- Do not override global `config.compress*` and `config.concatenate*` HOT 4
- Use Middleware instead of hooks to make the tiny HOT 1
- TYPO3 12 HOT 5
- AssetCollector compression not working anymore HOT 4
- Loading error by using email mailto HOT 16
- Compression with fonts inside CSS HOT 6
- [BUG] CSS compression filename conflict
- [Bug] Asset compression (CSS/JS) is generated with every page view HOT 2
- New Tag for TS fix HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from min.