Coder Social home page Coder Social logo

Comments (2)

jeffkreeftmeijer avatar jeffkreeftmeijer commented on July 26, 2024

Hi Kee,

Those nasty IE javascript errors usually have something to do with stray commas and forgotten semicolons. I've updated the wysihat_engine.js file and if you ask me the whole thing is nice and tidy now.

I've pushed a fix and updated the gem on gemcutter. Also, I've updated the demo, so it's a good idea to just clone that and see if it works :)

I haven't checked this in IE yet (and I'm not even entirely sure that this was the problem), but I think this will solve your issue. I will check it out as soon as possible.

Update:

I found myself a beige box and checked it out. The problem was that the addButton calls got called before the toolbar was created. That was odd, because it only happened in IE.

The creating of the editor and adding of the buttons were divided into two functions.

Since they were called at the same time I decided to put them both into one function and call that one instead of the addButtons one in previous versions. This function is called wysiHatify().

Now IE doesn't have a problem trying to figure out which one to call first anymore, since there's only one.

This should be fixed now. Thanks for reporting! :)

from wysihat-engine.

keeran avatar keeran commented on July 26, 2024

Yes can confirm it's sorted in IE7 now, nice one :) Checking for possible regressions in IE8 as soon as I sort out a VM :)

from wysihat-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.