Comments (2)
I am not sure this is really needed. (This will be my initial feedback on
nearly any
feature addition to GIN. I am trying to keep things as simple as possible. :))
The alternative is to make your EntryPoint pretty trivial and to have it create
your
Ginjector and then create MyEntryPointImpl or whatever you like.
MyEntryPointImpl can
then be created via GIN's normal goodness.
OTOH, Guice supports method injection so we probably will end up doing so
eventually.
I see this patch doing two things:
1) Allowing method injection in addition to constructor injection
2) Allowing a Ginjector interface to let you request injection on a pre-created
object
Might it be clearer to do these in two phases? Once the current big pending
change
(GinModule) is landed I'll try to follow up better on this patch.
Original comment by [email protected]
on 22 Sep 2008 at 8:49
from google-gin.
Patch accepted from aragos and committed in r53. Code review:
http://codereview.appspot.com/5863
Original comment by [email protected]
on 27 Oct 2008 at 12:20
- Changed state: Fixed
- Added labels: Type-Enhancement
- Removed labels: Type-Defect
from google-gin.
Related Issues (20)
- Warning for missing annotation source code HOT 3
- Inject order should be constructors then fields then method HOT 7
- Unexpected error while using a private inner module: "Unable to inject an instance of XXX because it is a private class."
- GinFactoryModuleBuilder does not respect @Singleton HOT 3
- [Patch] Use own ClassLoader over SystemClassLoader to make Hosted Mode working HOT 3
- Views/widgets as singletons are present in memory and keep playing even after changing the view.
- Should have GIN error rather than gwt compiler error in package-private+generics corner case HOT 1
- Gin 2.1 not published in maven central HOT 2
- Gin 2.1 and Java6 results in: Unsupported major.minor version 51.0 Error HOT 6
- Allow double bound for identical definition HOT 2
- Publish GIN 2.1.1 to Maven Repository HOT 1
- Javadoc link broken in project home page HOT 1
- Using GinMapBinder with annotations produces Double-Bound exception HOT 1
- Gin trunk is incompatible to GWT trunk because of recent Guava 15 refactoring in GWT HOT 5
- java.lang.NoClassDefFoundError: sun/security/timestamp/Timestamper HOT 1
- Can't run with Google Web Toolkit 2.6 RC1 HOT 7
- GinModuleAdapter sometimes gives errors with singleton binding of concrete classes HOT 1
- GIN does not respect injection order when subclassing HOT 1
- Reduce code bloat for multiple instances of the same PrivateGinModule
- Move to Github HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-gin.