Gin unit tests do not compile against GWT trunk about google-gin

[GoogleCodeExporter]

The changes mostly simplified the API and added some logging.  I attached a fix 
for
the issues below, but won't submit this for a while - unless we want to require 
GWT
1.6 to run the tests?

In general, I agree that we shouldn't rely on the inner workings of the GWT 
compiler.
 However, since there is no (reasonable [1]) framework to run tests against the GWT
AST, I fear we need to keep this dependency alive for now.  


[1] We could try to re-create the AST with EasyMock, but that would (a) still 
make us
dependent on the GWT implementation (since all mocks would have to exactly 
mirror
that) and (b) require a huge amount of work, since we have to exactly re-create 
the
AST generation.  Due to theses issues I don't think we can mock this out at the 
moment.

Original comment by aragos on 5 Jan 2009 at 5:09

• Changed state: Fixed

Attachments:

• Fix_for_GWT_1_6.patch

[GoogleCodeExporter]

Hi aragos, could you not apply this patch until 1.6 comes out? Requiring the 
trunk to run tests will make building 
a new release very inconvenient (the build runs the tests, right?). Thank you.

Original comment by [email protected] on 5 Jan 2009 at 2:24

[GoogleCodeExporter]

Since GWT 1.6 is now released, here's an up-to-date patch for our tests:
http://codereview.appspot.com/67106

Original comment by aragos on 25 May 2009 at 8:13

• Changed state: Review

[GoogleCodeExporter]

Fixed in r103.

Original comment by [email protected] on 31 May 2009 at 10:19

• Changed state: Fixed

[GoogleCodeExporter]

Fixed in r103.

Original comment by [email protected] on 31 May 2009 at 10:19