Coder Social home page Coder Social logo

Comments (7)

bagelbits avatar bagelbits commented on July 21, 2024

I agree with your first point Replace all Unicode single right quotation marks with ASCII apostrophe. I think that makes a lot of sense.

To your second point Use Unicode left and right double quotation marks for all embedded quotes: I wonder if it actually makes sense for you to do the opposite? If we use ascii, it does make it easier to type and also you have consistency of ASCII usage for both kinds?

from 5e-database.

syntaxaire avatar syntaxaire commented on July 21, 2024

I could do that, and programmatically do opening and closing quotation marks in my own application. If we convert the database to ASCII, should we also replace the Unicode em dashes, en dashes, multiplication symbols and bullet points? (Most of these code points are in the Spells file as well.)

from 5e-database.

bagelbits avatar bagelbits commented on July 21, 2024

Hmmmm. I think that might make sense. What do you think?

from 5e-database.

syntaxaire avatar syntaxaire commented on July 21, 2024

Sure, converting the JSONs to pure ASCII probably wouldn't hurt. I can put in sensible conversions for em- and en-dashes like double dash and single dash, asterisks for bullets, and x for times symbol. PR will come with spelling corrections as well.

from 5e-database.

bagelbits avatar bagelbits commented on July 21, 2024

Sounds good to me!

from 5e-database.

syntaxaire avatar syntaxaire commented on July 21, 2024

PR coming shortly.
This is as was discussed in the issue except that instead of replacing bullet points with asterisks, I replaced them with hyphens. The reason for this is that asterisks are used in a few places in the SRD for footnotes, like in the Archmage entry. You can get bullet points from the ASCII version by converting a newline followed by a hyphen to a bullet. Using asterisks would have converted footnotes to bullets as well.

from 5e-database.

bagelbits avatar bagelbits commented on July 21, 2024

Thank you again for doing this!

from 5e-database.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.