Coder Social home page Coder Social logo

Comments (10)

mickael-menu avatar mickael-menu commented on June 2, 2024 2

This particular issue should be fixed in the next version of the Kotlin toolkit, see readium/kotlin-toolkit#294

from react-native-readium.

mickael-menu avatar mickael-menu commented on June 2, 2024 1

You should receive a Slack invitation by mail soon, let me know if you don't. Our Zoom calls are notified on the #general channel but we're taking a break until end of January to figure out what's the best timing and cast.

from react-native-readium.

mickael-menu avatar mickael-menu commented on June 2, 2024 1

The changes regarding the Preferences API and the HTTP server are optional in 2.3.0. However the Decoration.extras and PDF support sections in the migration guide are required to upgrade.

from react-native-readium.

jspizziri avatar jspizziri commented on June 2, 2024

@M-HARIS-97 please create a reproduction in the example app. I haven't seen this before.

from react-native-readium.

M-HARIS-97 avatar M-HARIS-97 commented on June 2, 2024

@jspizziri This epub has overflow-x: hidden / overflow-x: visible CSS for the <body> tag. That is what is causing this.

from react-native-readium.

jspizziri avatar jspizziri commented on June 2, 2024

@M-HARIS-97 glad you sorted it out.

from react-native-readium.

jspizziri avatar jspizziri commented on June 2, 2024

@mickael-menu , wow! Thanks for letting us know! 🙏

How did this come across your radar in this project?

from react-native-readium.

mickael-menu avatar mickael-menu commented on June 2, 2024

I found this wrapper thanks to you actually 😄 I'm subscribed to the activity now.

Feel free to come participate in our bi-weekly Zoom calls or API discussions on Slack and the Readium repos. The more the merrier!

from react-native-readium.

jspizziri avatar jspizziri commented on June 2, 2024

@mickael-menu I just might do that! Where can I find the invite links?

from react-native-readium.

jspizziri avatar jspizziri commented on June 2, 2024

@M-HARIS-97 kotlin-tooklit 2.3.0 has been released. As mentioned above the fix for this issue is contained in that release.

What remains to be done is to upgrade this library to use that version. Based on the migration guide it looks like there are several changes we'll need to make (specifically to how preferences work) in order to upgrade.

I encourage you to investigate and put together a PR if you need this fix soon. As for our team, it will probably be a while before it falls on our roadmap.

from react-native-readium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.