Comments (2)
Feel free to discuss & add something that you think should be present in 1.0 release
from rosu-memory.
I think a slight change to json structure (and Values
) are warranted as the current form of it is a bit too clunky:
- Move pp and sr to separate structs (because I plan on adding 100-95% acc pp calculation later on, as well as gradual sr calculation, and having many pp/sr values in main struct would be bad UX for overlay creation)
- @uzervlad wanted to get Bancho data to a usable state, and that would create some overlaps (specifically username, might be more than that)
- Similar issue might happen if we start storing pre- and post-mod map stats like AR/CS and BPM, so splitting song select stuff from gameplay data could be handy
- Implementing some struct methods could be nicer this way, especially in the longer run
I might be missing downsides but in general a slight refactor of Values
seems like a nice thing to do (if we agree on what should go where)
from rosu-memory.
Related Issues (20)
- Failure after "random beatmap" is spammed HOT 1
- Score data isn't reset when changing state to ScoreSelect HOT 6
- Reach data parity with StreamCompanion HOT 1
- Adjust beatmap-related calculations to use Gradual calculations HOT 2
- `new_map` seems to never actually be true HOT 1
- Current (gradual) calculations occasionally panic HOT 2
- Reading loop occasionally resets HOT 2
- pp is 0 on results screen and song select HOT 2
- calculates wrong star rating for converted maps HOT 4
- Converted sr not calculated correctly for converted catch maps HOT 2
- "Skipped gameplay reading, probably it's not ready yet" HOT 7
- "data.gameplay.slider_breaks" always returns 0 HOT 1
- Allow to specify pid manually
- don't hang whole reading loop when pp failed to calculate HOT 1
- fix: check ruleset_addr for zero's HOT 1
- "data.fc_pp" doesn't show actual "if fc" pp HOT 1
- "data.current_pp" seems to display higher pp than actually obtained HOT 3
- Takes a minute or so for the overlay to start HOT 2
- Cannot access memory at negative address in windows HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rosu-memory.