Coder Social home page Coder Social logo

Prepare for 1.0 release about rosu-memory HOT 2 CLOSED

486c avatar 486c commented on August 17, 2024
Prepare for 1.0 release

from rosu-memory.

Comments (2)

486c avatar 486c commented on August 17, 2024

Feel free to discuss & add something that you think should be present in 1.0 release

from rosu-memory.

S1n1st3rn3ss avatar S1n1st3rn3ss commented on August 17, 2024

I think a slight change to json structure (and Values) are warranted as the current form of it is a bit too clunky:

  • Move pp and sr to separate structs (because I plan on adding 100-95% acc pp calculation later on, as well as gradual sr calculation, and having many pp/sr values in main struct would be bad UX for overlay creation)
  • @uzervlad wanted to get Bancho data to a usable state, and that would create some overlaps (specifically username, might be more than that)
  • Similar issue might happen if we start storing pre- and post-mod map stats like AR/CS and BPM, so splitting song select stuff from gameplay data could be handy
  • Implementing some struct methods could be nicer this way, especially in the longer run

I might be missing downsides but in general a slight refactor of Values seems like a nice thing to do (if we agree on what should go where)

from rosu-memory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.