Coder Social home page Coder Social logo

Recording lock option about recordview HOT 17 CLOSED

3llomi avatar 3llomi commented on July 19, 2024
Recording lock option

from recordview.

Comments (17)

Tougee avatar Tougee commented on July 19, 2024 2

@sepehr1014
You can check this project same as Telegram

from recordview.

3llomi avatar 3llomi commented on July 19, 2024 2

@Tougee Good Job man it's Great.
it would be awesome to add Lock feature to 'Record View' 😉

from recordview.

3llomi avatar 3llomi commented on July 19, 2024 1

@Mustafa-Altameemi Not yet. not sure if i can add this in the near future.

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

Hi @sepehr1014 ,
Yes i have this idea in my mind, it's just needs some time to make it work.

from recordview.

Mustafa-Altameemi avatar Mustafa-Altameemi commented on July 19, 2024

Hi @sepehr1014 ,
Yes i have this idea in my mind, it's just needs some time to make it work.

Thanks for your library. I'm wondering if you have done the recording lock by now or not?

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

if anyone is interested, i've added this feature in a separate branch since it's in Beta.

implementation 'com.github.3llomi:RecordView:3.1.0beta1'

looking forward for your feedback.

from recordview.

waqaruet avatar waqaruet commented on July 19, 2024

any update on beta version of lock option? I see a lot of bugs and incomplete functionality in Lock mode. Please inform what's the plan to take it out of beta?

from recordview.

waqaruet avatar waqaruet commented on July 19, 2024
  1. When we hold mike in Lock mode enabled, mike position changes from its base position which looks awkward
  2. If user enters the lock mode and then get into onPause, onStop state then their is no handling listener or way to take it out of lock mode programatically or it should automatically stop.
  3. Lock animation should be customiseable.

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

Hey @waqaruet ,
Unfortunately I don't have enough time for this, I will try my best to finish it ASAP.

Thanks for your notes though, I just wanted to know that you are using the latest beta V3.1.0beta6 ?

  1. The current implementation works ONLY if RecordLock AND RecordButton are in different parents. i need to handle the case where both have the same parent.

  2. Yes, I am thinking of adding something like recordView.finishRecord() so we can call it inside onPause() for example to Finish the record

  3. let me know your thoughts about how can we make it customizable.

from recordview.

waqaruet avatar waqaruet commented on July 19, 2024

@3llomi Thanks for your response, appreciate that,
I'm using V3.1.0beta6

  1. Yes, RecordLock AND RecordButton are in different parents.
  2. recordView.finishRecord() and recordView.cancelRecord() would be really handfull
  3. Customization like to make similar to whatsapp i.e Shimmer text, shimmer text color , background color , lock Icon , lock animation on/off. unlock icon

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

Thanks for your feedback! @waqaruet

  1. can you reproduce it? like posting a Video sample?

from recordview.

waqaruet avatar waqaruet commented on July 19, 2024

Yes, I can re-produce it, attaching video as well.
You can see record button changes its position on touch

WhatsApp.Video.2021-09-18.at.10.32.05.PM.mp4

.

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

@waqaruet Thanks for the Video!
I will try to fix it ASAP.

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

Yes, I can re-produce it, attaching video as well. You can see record button changes its position on touch

WhatsApp.Video.2021-09-18.at.10.32.05.PM.mp4
.

@waqaruet Just pushed 3.1.0beta7. it should be fixed now

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

now it's fully working with V3.1.1 🎉🎉

from recordview.

Mahesh160393 avatar Mahesh160393 commented on July 19, 2024

@3llomi How to change the lock icon image?

from recordview.

3llomi avatar 3llomi commented on July 19, 2024

@Mahesh160393 You can't.
I used two images for the Lock Icon, so if you tried to change both images it may result in incorrect behavior since the Lock size may differ.

from recordview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.