Coder Social home page Coder Social logo

Extension v1.0.0 '1Password: Get from 1Password' resulted in an error (Cannot read properties of undefined (reading 'kind')) about op-vscode HOT 12 OPEN

petercrocker avatar petercrocker commented on August 22, 2024 1
Extension v1.0.0 '1Password: Get from 1Password' resulted in an error (Cannot read properties of undefined (reading 'kind'))

from op-vscode.

Comments (12)

petercrocker avatar petercrocker commented on August 22, 2024 1

Thanks @jodyheavener I saw #1 but seemed to indicate it was fixed in op-vscode v0.1.2 hence submitting this since I'm on the 1.0 later version now. Happy to help debug further, let me know what would be useful.

from op-vscode.

petercrocker avatar petercrocker commented on August 22, 2024 1

Hi @jodyheavener just tested again:

  1. Issue persists with that specific item only. That item has more complexity in it for sure. It's got sections defined, which seems to be the only unique thing about that item. Maybe that could be worth testing?
  2. Yes biometric unlock is fully setup, but as you allude to, i'm using it in clamshell mode when it's on my desktop plugged in to a thunderbolt dock.

That said, I've duplicated the item in question, and I've been removing content. Removed the sections, removed the OTP, yet it's still complaining each time with the error. It's only got a user and pw defined now! Don't know what's unique about that item, but the vs code extension clearly doesn't like it!

If you can tell me where/how to get debugging info, or run vs code extension in debug mode, happy to help!

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024 1

Hi @maxisam, thanks for your comment. I think you may be talking about a separate issue, though I can tell you that the extension does construct the secret references; they come directly from the CLI. You might consider opening a post on the CLI forums.

@petercrocker et al, I'm sorry I haven't been able to nail down this issue yet, but it's not been forgotten!

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024

Hey @petercrocker thanks for the detailed issue (and the kind words 😄)! I'll dig into this a bit to see what it could be. It looks related to #1, which was seemingly resolved by another tweak I made, but maybe it was just a fluke. I'll see what I can find!

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024

@petercrocker Just a heads up, I deleted the screenshot comment because the last field in it was partially unmasked. To be extra safe you might consider rotating that value.

from op-vscode.

petercrocker avatar petercrocker commented on August 22, 2024

doh! thanks, will do!

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024

Hey @petercrocker I'm still trying to track down this issue, so I wanted to check to 1) see if this issue continues to persist with this specific item, or all items, 2) are you using 1Password CLI with biometric unlock fully set up? I see you noted that when authorizing you're asked to "Accept", which I believe comes from when you're using the CLI in clamshell mode (We still shouldn't see this issue but wanted to clarify)

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024

Hey @petercrocker, it's been a while, and I haven't been able to narrow down this specific issue, but I wanted to check in to see if you were still able to reproduce it.

If you can tell me where/how to get debugging info, or run vs code extension in debug mode, happy to help!

Currently the extension avoids logging anything like CLI output to prevent accidentally writing sensitive details to disk, so it's sort of a shot in the dark with certain issues, unfortunately.

from op-vscode.

petercrocker avatar petercrocker commented on August 22, 2024

Hey @jodyheavener thanks for bringing this up again! Ok, so I tried a few things. I think I've narrowed it down, but not sure exactly what it's hanging on. Running op on the items it's barfing on show metadata that I can't see in 1password UI, so can't edit and remove, but seem to be the unique thing about the vault item. I've obfuscated the output a bit:

op item get Item2
ID:          mdwf5tsxxfbobgiftxxzidblah
Title:       Item2
Vault:       MyVault (u6temkdqebd6zccajlzzdkblah)
Created:     3 years ago
Updated:     35 seconds ago by Me
Favorite:    false
Version:     7
Category:    LOGIN
Fields:
  password:             removed!!
  :                     Toggle navigation
  username:             [email protected]
  password:             mypassword
  :                     Sign Up for MySite
  region:               eu-central
  :                     Modal Test
  :                     ×
  :                     Skip Quick
  :                     ×
  :                     Take Me To My Account
  one-time password:    123456
URLs:
  website:    https://somesite.com (primary)

So it's this section I don't see in the UI:

:                     Sign Up for MySite
  region:               eu-central
  :                     Modal Test
  :                     ×
  :                     Skip Quick
  :                     ×
  :                     Take Me To My Account

And if I create a new vault entry from scratch, with just user/pw then of course the metadata isn't in there, and the VScode extension works fine!

As a reminder, this is the error the 1p extension kicks out when trying to reference this:
Command '1Password: Get from 1Password' resulted in an error (Cannot read properties of undefined (reading 'kind'))

Could that help?

from op-vscode.

tkelkermans avatar tkelkermans commented on August 22, 2024

Hi,

I get the same error with :

  • op-vscode version: v1.0.2
  • 1Password for Mac 8.9.7 (80907031)
  • VS Code version: Version: 1.72.2 (Universal)
  • CLI version: 2.7.2
  • OS: macOS 12.6 (21G115)

Did you find how to solve that ?

from op-vscode.

maxisam avatar maxisam commented on August 22, 2024

the format from get from 1password is wrong. It shouldn't include section in output.

image

from op-vscode.

jodyheavener avatar jodyheavener commented on August 22, 2024

This issue is still ongoing and we don't yet have a solution, so I'm going to open this up to Hacktoberfest submissions if anyone is brave enough or has any wild ideas. Good luck!

from op-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.