Comments (9)
Can you provide a snippet of the smali code around one of the lines that it is
complaining about?
Original comment by [email protected]
on 9 Jun 2010 at 1:17
- Changed state: Accepted
from smali.
[deleted comment]
from smali.
Line 396 in AddBookmarkPage.smali: invoke-virtual {v16 .. v16},
Ljava/lang/String;->length()I
Line 5673 in BrowserActivity.smali: invoke-virtual {v16 .. v16},
Ljava/lang/String;->length()I
Line 856 in BrowserProvider,smali: invoke-virtual {p2 .. p2},
Ljava/lang/String;->length()I
Original comment by [email protected]
on 9 Jun 2010 at 1:29
from smali.
Can you provide some context to one of those? I'd like to see the code around
one of those locations as well
Original comment by [email protected]
on 9 Jun 2010 at 1:35
from smali.
From AddBookmarkPage.smali:
.line 179
.local v6, emptyTitle:Z
:goto_31
invoke-virtual {v13}, Ljava/lang/String;->trim()Ljava/lang/String;
move-result-object v16
invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
move-result v16
if-nez v16, :cond_79
const/16 v16, 0x1
move/from16 v7, v16
from BrowserActivity.smali:
.line 363
.local v10, jsFlags:Ljava/lang/String;
invoke-virtual {v10}, Ljava/lang/String;->trim()Ljava/lang/String;
move-result-object v16
invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
move-result v16
if-eqz v16, :cond_28b
.line 364
move-object/from16 v0, p0
iget-object v0, v0, Lcom/android/browser/BrowserActivity;->mTabControl:Lcom/android/browser/TabControl;
move-object/from16 v16, v0
invoke-virtual/range {v16 .. v16}, Lcom/android/browser/TabControl;->getCurrentWebView()Landroid/webkit/WebView;
move-result-object v16
Original comment by [email protected]
on 9 Jun 2010 at 1:42
from smali.
Gotcha, thanks. It's using the /range style of registers for a non-range
invoke. weird. I'll look into it, thanks
Original comment by [email protected]
on 9 Jun 2010 at 1:45
from smali.
Excellent, thanks. :-)
Original comment by [email protected]
on 9 Jun 2010 at 1:48
from smali.
Yeah, I noticed this problem too. Sometimes there are normal (not range)
invokes for a range of registers, also there are e.g. {v1 .. v2} or even {v1 ..
v1} invokes everywhere.
Original comment by Brut.alll
on 9 Jun 2010 at 3:29
from smali.
Fixed :)
http://code.google.com/p/smali/source/detail?r=731
Original comment by [email protected]
on 10 Jun 2010 at 1:44
- Changed state: Fixed
from smali.
Related Issues (20)
- Deodexing from Gingerbread fails HOT 6
- Deodexing from vzwlbs.odex fails HOT 3
- Deodexing from Gingerbread fails HOT 1
- smali and baksmali result in ClassNotFoundException HOT 2
- Microsoft Security Essentials claims there is a virus in baksmali HOT 4
- android honeycomb 3.0 HOT 1
- Baksmali is broken on HoneyComb HOT 23
- Exception occured when I used "-r" option. HOT 4
- Having troubles with baksmali HOT 1
- Cannot Deodex Settings.odex HOT 5
- Error occured while while using baksmali on teeter.odex HOT 3
- Can't assemble .dex from an disassembled .odex HOT 3
- baksmali can't fetch classes from framework.odex HOT 3
- The function ByteArrayInput.readLong in dexlib utils is incorrect HOT 2
- Re-odex services.odex problem HOT 4
- Problem finding BOOTCLASHPATH HOT 2
- Register args in the v15+ range HOT 4
- Fail to deodex MusicPlayer.odex HOT 2
- Error when recompile a dex file HOT 7
- line -/
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smali.