onRegionClick error in IE8 about jqvmap

[sonicparke]

I figured out what that code does. If you comment it out the map retains the selected color on any region you click rather than reverting back to the unselected fill color. Sucks that IE8 craps out on that.

[sonicparke]

I replaced it with this for now:

if(jQuery.browser.msie) {

    } else {
      map.countries[key].currentFillColor = map.countries[key].getOriginalFill();
      map.countries[key].setFill(map.countries[key].getOriginalFill());
    }

[manifestinteractive]

@sonicparke Any way you can make these changes and do a pull request? I can test them and merge them into the code.

[sonicparke]

Sorry I'm just now getting back to this. I would like to do a pull request if you still need it but I'm a github noob and apparently can't figure out how to do it.

[marshallino16]

hi, is-it possible to know how do you succed to use jqvmap in IE8 ?
I need your solution, i'm a little bite desperate cause' it works great in Firefox and Chrome but in the firme, people use IE8...

Thanks,

[sonicparke]

Which problem are you having in IE8? Is it the one in the original post?

[marshallino16]

my map isn't show... just the tooltips

With the compatibility mode of IE8, my map is showing but it's just horrible to see it, the Vector looks like random...
Do you have an idea to solve it ?

[sonicparke]

I think I had that problem but can't remember what it was. Maybe an extra comma and the end of a JSON array? Do you have a url I can look at?

[marshallino16]

yes : it's in development for the moment

http://link.net

[sonicparke]

Is this what you get? http://img.skitch.com/20121011-dyscp9wubpn7u46hypyjmue973.png

[marshallino16]

Yes that's it, normal issue ? what's wrong ? It's perfect under chrome for example

[sonicparke]

I got a response and a fix from bjornd who wrote jvectormap which jqvmap is based on. Here is the thread on that github repo. bjornd/jvectormap#23 (comment) The fix is listed as issue "#23 Path component string should be trimmed before processing" posted by bjornd in that thread. That should fix it.

[marshallino16]

I don't understand what i have to do, last solution is to redevelop my map with jvectormap but i don't Know where i can find vector's list of all department.

Thanks a lot for your help

[sonicparke]

OK. Go here: bjornd/jvectormap@aabe3c9

Search your 'jquery.vmap.js' file with line highlighted in Red (it's this one):

coords = coords.replace(/(\d)-/g, '$1,-').replace(/\s+/g, ',').split(',');

Replace it with the lines highlighted in Green (these):

coords = coords.replace(/(\d)-/g, '$1,-')
.replace(/^\s+/g, '')
.replace(/\s+$/g, '')
.replace(/\s+/g, ',').split(',');

That should fix it for you.

[marshallino16]

ah ah you saved my ass, you can't imagine,

Thank you very very much,

By the way, sorry for my English if it's so bad.

[sonicparke]

No problem. Your English is fine. Glad it's working for you now.

[seize37]

Hi Sonicparke!
I just tried your solution but doesn't works for me. My map looks still random...
What things I have to do to get the map look's better?
Thanks

[seize37]

Sorry!
I forgot things... I did a mistake in my files!
Thoses lines works perctly!

Thanks!

[sonicparke]

Glad you got it working.

[KaylanBrunet]

Could you take a look at my code on http://www.nsworld.org/development in IE8 and tell me what's wrong. I can't figure out what's the problem. It works perfectly in any other browser except Ie and more then 35% of our client visit our website with IE8 & 7 :/