Coder Social home page Coder Social logo

Comments (4)

robinstraub avatar robinstraub commented on June 14, 2024 1

Hello @FabijanC, sorry for the delay. I had a more thorough look into it and got some advice from @Nathan-SL.

Basically the "contract.json" is represented by the "metadaPath" and the "contract_abi.json" is represented by the "abiPath". So this issue is about getting rid of the "abiPath".

There are 2 modifications needed to resolve this issue that I would consider breaking changes:

I see 3 options to address this:

  1. Create a breaking change and get rid of the abiPath (including removing the getAbiPath function and the interface inheritance)
  2. Consider the getAbiPath function and the interface inheritance important and disregarding the issue
  3. Marking the abiPath property as optional, and deriving it from the metadataPath (but then the logic of getContractFactoryUtil)[https://github.com/Shard-Labs/starknet-hardhat-plugin/blob/master/src/extend-utils.ts#L13] becomes redundant and it might need a bigger refactoring)

I'd say if the breaking change is not a problem we go with solution 1.

Feel free to ping me on telegram if you want to discuss this more thoroughly.

from starknet-hardhat-plugin.

FabijanC avatar FabijanC commented on June 14, 2024

Also note, the content of the contract_abi.json is a property of the object in contract.json. Perhaps this can be taken into account when addressing this issue.

from starknet-hardhat-plugin.

FabijanC avatar FabijanC commented on June 14, 2024

@robinstraub Sorry for the delay in replying. I don't understand how removing abiPath would allow users to load contracts only with ABI. Shouldn't it be the other json artifact that would require removing? Also note that since the introduction of Cairo 1 the plugin currently requires another artifact: contract.casm (due to Sierra mid-layer).

from starknet-hardhat-plugin.

ivpavici avatar ivpavici commented on June 14, 2024

This will probably be handled as well by #396

from starknet-hardhat-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.