Set Filters and yesno arg about sa818

[0x9900]

Congratulations, you found a bug.
I pushed a new version. The message should be more clear now.
Thanks
-fred-

[sp2ong]

OK nice and thank you very much

[sp2ong]

Hi
Does it look like I am wrong in my suggestion ? Today I turn on DEBUG mode and I see that

a818 --debug filters --emphasis yes --highpass yes --lowpass yes
SA818: DEBUG: Namespace(debug=True, emphasis=True, func='filters', highpass=True, lowpass=True, port=None)
SA818: DEBUG: Sending: AT+SETFILTER=0,0,0

so AT+SETFILTER=0,0,0 it is mean that filters are ENABLED

sa818 --debug filters --emphasis no --highpass no --lowpass no
SA818: DEBUG: Namespace(debug=True, emphasis=False, func='filters', highpass=False, lowpass=False, port=None)
SA818: DEBUG: Sending: AT+SETFILTER=1,1,1

so value 1 corresponds to "bypass" so isn't it enabled???

Perhaps I misunderstand the term "bypass"

in manual SA818 is for example for pre/de emphasis:

PRE/DE-EMPH:
1: emphasis bypass
0: emphasis normal

[sp2ong]

I suppose it is that you are using negation on YES/NO value in cmd

cmd = "{}={},{},{}".format(self.FILTER, int(not opts.emphasis),
int(not opts.highpass), int(not opts.lowpass))

I don't know why is used negation input value if
in "def yesno()" YES is equivalent to 1

def yesno(parg):
yes_strings = ["y", "yes", "true", "1", "on"]
no_strings = ["n", "no", "false", "0", "off"]

[0x9900]

I have fixed that in the new version

[sp2ong]

Thank you very much

73 Waldek SP2ONG