Coder Social home page Coder Social logo

Comments (10)

Clover-Zero avatar Clover-Zero commented on June 29, 2024 2

Did the site you mentioned display different CGs of the same character?

To answer your question, no, it didn't. Still, I think some kind of imagery would be nice nonetheless. Though that is also up to personal preferences.

I personally quite like how you handle background images. I still haven't found a good way to handle them, either. It's really hard. Perhaps making an option to show full background images might be the best choice for now.

from arknightsstorytextreader.

050644zf avatar 050644zf commented on June 29, 2024

Thank you for your support!

I find it quite troublesome that often enough i have to click and open the image of the background, I'd prefer a much clearer preview.

Well, the reason i want to cut the Background element as stripe is because Background is less important than Image which provides unique information, and Background images are reused across different events, so it will be kind of waste of space if showing the whole Background image there. Though i can provide an option for showing full Background image, adding too many options isn't always a good idea. Anyway, i would like to hear more idea about handling the images in reader.

Also, I'd like, instead of having only their name displayed, also an image of the character that's talking. An example of what I'm talking about can be found in the game farthest (game no saihate in japanese) text reader.

Adding character CG in reader is a feature that i planned for a long time. However, i have the following problems need to be deal with first:

  • Source of Character CG.
    The Character CGs contain the whole figure of the character in the ingame story view. And showing the entire figure takes too much room and increasing loading time. So, to realize the feature that display charatcer's avatar only, i need to find a way to get the avatar. Aceship Toolbox has operators' avatars but no NPCs' avatar. And each operators' has only one avatar while u can see the facial expressions changes among different CGs of the same character ingame.

    Did the site you mentioned display different CGs of the same character?

  • Get the correct character CG
    the character CG filename is decided by the Character line, like this

[Character(name="avg_2023_ling_1#8$1", name2="avg_npc_140#1", focus=1)]
[name="Ling"]Drinking lone does stifle. I bid you wine with me. Tell of your dream.
[Character(name="avg_2023_ling_1#8$1", name2="avg_npc_140#1", focus=2)]
[name="Stonemason"]Are you one of those... dream interpreters? I've heard people can make a living with that, in some parts of Yan.

ASTR complies the raw story file line by line. Here to decide which CG Ling should use, i have to look at the line before, and pick the focused Character CG.
However, that may not cover all the possible situation, sometimes it got more complicated. So, I need to research more about it.

  • How to elegantly showing them

For some reasons, I'm pretty busy recently and may not have time to spend on them. Even tho i will try my best to do it. Stay tuned!

from arknightsstorytextreader.

Ciel-exe avatar Ciel-exe commented on June 29, 2024

Hi, thanks for your answer.
I'm fine with just a single avatar. If in the future you'd like to take on the work to add also emotions to that i'd be even more glad, but as Clover-Zero said, "I think some kind of imagery would be nice nonetheless.", which is the reason i opened this issue.
I agree with you on the background choice, as long as image classes are fully displayed. Having them fully displayed every time could be troublesome, but having them the way they are right now, well, i think i might not be the only one who would prefer some change. Trying to find some balance might be difficult, but for now, despite it wouldn't be perfect, i think it could add something more to the experience, which is already great. I think having a checkbox to display the background as full might be a good idea, as Clover-Zero also stated, but just in case, I want to suggest using a slider to adjust the preview size, this way no one should complain.
Also, while i'm here, i'd like to ask you another thing:
image
I don't exactly like how this sticky menu is in the way of the text, but i appreciate the fact that we can have a sticky menu like this one. Maybe bringing it a little more close to the top of the window might be the right call? Idk, this is a really dumb suggestion and if you don't want to listen to it i'm fine with it.

from arknightsstorytextreader.

050644zf avatar 050644zf commented on June 29, 2024

@Clover-Zero

Perhaps making an option to show full background images might be the best choice for now.

Okay I will work on it.

@Ciel-exe

I don't exactly like how this sticky menu is in the way of the text, but i appreciate the fact that we can have a sticky menu like this one. Maybe bringing it a little more close to the top of the window might be the right call? Idk, this is a really dumb suggestion and if you don't want to listen to it i'm fine with it.

That's totally my poor coding ability fault, I'm new to frontend programming and I have to admit that I'm not good at handling such kind of style issue. So that leads to some style in ASTR didn't work as expected, like here this navigation bar should be attached to the top rather than leaving a small spaces.

Anyway I will note this issue, however I'm really busy recently so i may not have time to work on it. If i got time i will implement a total fix of these style issues and further improve the UI experience.

Thank you for your continued support. 😃👍🏻

from arknightsstorytextreader.

Ciel-exe avatar Ciel-exe commented on June 29, 2024

Thank you for your answers and time. Looking forward to the changes, take it easy.

Sidenote: if you're doing the front-end in vue/vuetify i can try to give you tips if you have problems

from arknightsstorytextreader.

050644zf avatar 050644zf commented on June 29, 2024

Thank you for your answers and time. Looking forward to the changes, take it easy.

Sidenote: if you're doing the front-end in vue/vuetify i can try to give you tips if you have problems

ASTR is built with vue3 with Naive UI framework. The sticky style navigation bar is realize with n-affix component (doc) in this line

I slightly remember that when i implement this i met some unexpected behavior, then i gave up fixing it. If u have any better implementation or clues about it, a PR will be appreciated. BTW you can raise this as another issue here, we will focus on story cg issue here mainly.

from arknightsstorytextreader.

Ciel-exe avatar Ciel-exe commented on June 29, 2024

Yes, you're right,
Anyway I didn't want to open a Pull Request for a suggestion i probably couldn't give, that's why I asked beforehand. I'm most experienced in vuetify, where this would have just been a matter of changing a classname. Anyway, to fix that line you just need to replace the "30" with a "0", probably, as i just fixed it by highlighting the element in chrome and changing the top value as showed here.
image

As it's not pertaining with the story cg issue, i'll refrain from saying further here, and in case i'll open another PR as you suggested.

from arknightsstorytextreader.

050644zf avatar 050644zf commented on June 29, 2024

@Ciel-exe @Clover-Zero
i added background display options in wv0.99 of ASTR. You can check them in settings.

from arknightsstorytextreader.

Ciel-exe avatar Ciel-exe commented on June 29, 2024

Thanks, now it's perfect as long as the background is concerned, in my opinion. I really like it. I'd close the issue, but the part of adding avatars has not yet been implemented, so for now i'll leave this issue here, in hiatus.

from arknightsstorytextreader.

050644zf avatar 050644zf commented on June 29, 2024

Feature about character figure art will be proceed in #40

from arknightsstorytextreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.