Comments (4)
I believe the best and simplest solution to this issue would be to use window.history.back()
in the piece of code that handles cancelled transitions. This would effectively change the URL back to whatever it was before the transition started, and it would preserve the ability to manually enter a new URL into the location bar (as opposed to requiring all URL changes to go through transitionTo
, for example).
In this solution, the router that aborted the transition should remain unaffected by the URL change because it would never actually update its components properties. The problem with this approach would be with other routers on the same page that are also observing the URL. They would effectively see two changes to the URL in quick succession, which would probably cause some weirdness.
The best way to solve this would be to use a dispatcher singleton that is responsible for listening to the URL and dispatching transition objects to routers that need to know about URL changes. When the URL changes, it would dispatch a new Transition
and wait for all transition hooks to resolve before actually telling routers to proceed with the transition and update their components.
from react-router.
The "transitions" example code runs fine with this commit.
from react-router.
It's actually one better than Ember's router because the URL is always kept in sync with what is on the page, even when it is manually changed but the transition is aborted.
from react-router.
:fistpump:
On Wed, Jun 11, 2014 at 9:34 AM, Michael Jackson [email protected]
wrote:
It's actually one better than Ember's router because the URL is always
kept in sync with what is on the page, even when it is manually changed but
the transition is aborted.—
Reply to this email directly or view it on GitHub
#22 (comment)
.
from react-router.
Related Issues (20)
- [Bug]: React router doesn't handle 'content://' URLs
- [Bug]: the state is not destroyed in the useFetcher hook with key parametr HOT 2
- [Bug]: Outlet component remounts in production when changing state above it HOT 2
- [Bug]: loader of Route running even if Route / Router is not rendered HOT 2
- [Docs]: Docs for shouldRevalidate make it sound like it is only for opting out
- [Bug]: `useLocation` out of sync with `history.location`, leads to potential renders of unmatched `Route`s
- [Bug]: useLoaderData triggers component re rendering even if the route remains unchanged HOT 1
- [Bug]: Cloudflare Pages - Outlet not working. HOT 33
- [Bug]: No route matches URL in production build HOT 3
- [Bug]: <Outlet/> Component is not working in deployment HOT 1
- [Bug]: `window.location` is not updated after a call to `router.navigate()` HOT 1
- [Bug]: router doesn't work in production build, only shows blank. HOT 1
- [Bug]: `<Navigate>` can be canceled by `navigate("?x")` even if guarded by `if(navigation.state === "idle")` HOT 1
- [Bug]: Using embed in a route with param causes it to render the whole application inside the div. HOT 1
- [Docs]: V6 - Mixing up <Route /> with lists [<Route />, <Route />] within one <Routes /> looks working but isn't mentioned in the docs and covered in unit tests. HOT 1
- [Docs]: update state after action behavior HOT 1
- [Bug]: "Cannot find module './index' or its corresponding type declarations" in react-router-dom/server.d.ts HOT 5
- [Bug]: <Outlet/> not working in build production with Vite. HOT 4
- [Bug]: React Router 6 useLoaderData returning cached data after fresh data is returned by the loader function HOT 5
- [Bug]: Incorrect Module Path in server.d.ts Causes TS2307 Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.