Comments (2)
I love fun issues. Expect me digging into this one later 😉
from typescript.
So in this case we end up with multiple inference candidates. We have:
- covariant:
[any]
- contravariant:
[]
and[a: number]
When multiple inference candidates are present, TS tries to select the best match based on different criteria. Since contravariant candidates don't overlap sufficiently enough the first one gets picked as overall inferredContravariantType
. Not: This is order-dependent so when you switch the order of ur union members it magically works because the other one gets picked there.
Since we have both inferredCovariantType
and inferredContravariantType
we also need to pick between those 2. It happens so that preferCovariantType
gets computed as false
in your case. It's rejected based on this check:
some(inference.contraCandidates, t => isTypeSubtypeOf(inferredCovariantType, t))
[any]
is not a subtype of either of the contravariant candidates, it's not a subtype of []
and it's not a subtype of [a: number]
. So it ends up picking the covariant candidate and it fails to typecheck ur arguments against inferred signature further down the line.
So it turns out one of my PR fixes this case alrady: #57909
But what happens in the implementation here got me thinking... why do we even have multiple contravariant candidates here? we do have that because the inference infer from each of your signatures separately here. This is kinda a single call though. TS is able to combine union (or intersection) signatures into one. Shouldn't we then infer from that combined signature here?
So that led me to creating this experiment that also addresses this issue: #58482
from typescript.
Related Issues (20)
- Union argument type with and spread operator
- Reuse original type nodes even when part of the node is not usable
- ts.createSourceFile trims leading newlines, causing stored line numbers to mismatch HOT 5
- Narrowing by type predicate fails to produce intersection type with weak type
- at the class getter property,why is need it initialize, if not then report error code is ts(2739) HOT 2
- Bloomberg TS5.5-beta feedback HOT 1
- Conditional Type Inference Bug in TS 5.x HOT 1
- Protected instance member inaccessible to same-class constructor via object destructuring assignment HOT 2
- [ERROR] 15:13:55 Error: Cannot set headers after they are sent to the client HOT 3
- Isolated declarations does not handle object getters and setters with different types HOT 6
- TypeScript does not support bigint literals in type literal keys HOT 1
- Isolated declarations uses type information when emitting computed object keys HOT 6
- Error: Debug Failure when importing `AssertionError` from `node:assert/strict` HOT 4
- transpileDeclaration - Errors on unresolvable globals HOT 2
- duplicate comments on decorated fields
- Type narrowing with union types create impossible case with else statement HOT 6
- Error when using `import()` type within JSDoc tag `@implements`
- Narrowring a readonly class with instanceof of does not work on the else branch HOT 1
- Disposables disposed of, even though they are passed to a wrapper and still in use HOT 3
- It's the JSON validator that complains here. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.