Coder Social home page Coder Social logo

Comments (9)

NeerajW avatar NeerajW commented on June 14, 2024 1

Have you tried https://desktop.github.com/ - desktop app for GitHub. I really like it. Makes things much simpler.

from mixedrealitytoolkit-unity.

mikthom avatar mikthom commented on June 14, 2024 1

Something worth considering in the case of Interpolator is that it's so general that it's reasonable to expect it to be used both in cases which should and shouldn't respect time scale.

If you have some object which is moving through your scene at a given rate using interpolator, that should definitely respect time scale, but as @danglingneuron pointed out, there may be cases like pause menus in which Interpolator should ignore time scale.

My recommendation for interpolator would be to add a flag which allows the developer to specify whether they would like scaled or unscaled time. I would expect this to default to scaled time both for backwards compatibility and because that seems to be the more common use case.

A search shows 4 different classes using Time.deltaTime. My recommendations are below:

File Purpose Recommendation
FpsDisplay.cs FPS counter Convert to unscaledDeltaTime
StabilizationPlaneModifer.cs Smoothly moving the stabilization place Convert to unscaledDeltaTime
Interpolator.cs Smoothly translating/rotating/scaling objects Add flag to allow user to specify scaled or unscaled time
UAudioManagerBase.cs Fading audio events Probably use unscaledDeltaTime. Usually messing with audio based on time scales is not the best, but if there are compelling use cases I would be open to hearing about them.

from mixedrealitytoolkit-unity.

NeerajW avatar NeerajW commented on June 14, 2024

@danglingneuron good suggestion. Would you like to make the change?

from mixedrealitytoolkit-unity.

danglingneuron avatar danglingneuron commented on June 14, 2024

If only I had learnt to use Git and Git tools :( I am still resisting the move from VSTS TFS backend) - will have to learn one day...

from mixedrealitytoolkit-unity.

danglingneuron avatar danglingneuron commented on June 14, 2024

Will have to learn it, since I have made several changes to HoloToolkit for my project.

from mixedrealitytoolkit-unity.

jwittner avatar jwittner commented on June 14, 2024

@danglingneuron And if you have any Git questions or issues, feel free to reach out and we can help you through it. =)

from mixedrealitytoolkit-unity.

stbertou avatar stbertou commented on June 14, 2024

I've used SourceTree (from Atlassian) for years, great tool !
But obviously this desktop tool is a much better option as it will works quite nicely with GitHub's flow

from mixedrealitytoolkit-unity.

jwittner avatar jwittner commented on June 14, 2024

@micthom-msft or @danglingneuron would either of you like to make this change?

from mixedrealitytoolkit-unity.

jwittner avatar jwittner commented on June 14, 2024

Closing until someone runs into the issues or someone claims this work.

from mixedrealitytoolkit-unity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.