Coder Social home page Coder Social logo

Comments (5)

jvoisin avatar jvoisin commented on June 14, 2024 1

It does make sense: "virtual-patch the call to this function, by disabling it", and "virtual-patch the call to this function, it it matches this and that condition, by allowing it".

from snuffleupagus.

jvoisin avatar jvoisin commented on June 14, 2024 1

Maybe from disable_functions to disable_function at least?

from snuffleupagus.

Kegeruneku avatar Kegeruneku commented on June 14, 2024

Looks like a better naming indeed, much more POLA-compliant

from snuffleupagus.

blotus avatar blotus commented on June 14, 2024

I'm not a fan of this.
disable_function is used not only for virtual patching, but also for disabling functions :)

sp.virtual_patching.function("system").drop() does not make more sense.

Maybe we should add a separate virtual_patching keyword for virtual patching rules, and keep disable_function for disabling function ? (but the configuration and the code will probably get very messy very quick)

from snuffleupagus.

buixor avatar buixor commented on June 14, 2024

As it requires extra code and extra keyword support forvirtual_patching to work, without adding any functionality, I suggest that we stick to disabled_function.

from snuffleupagus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.