Comments (4)
Ah I see, you are not misunderstanding it. The types for origin and destination are incorrect. I just opened a PR to correct that. Thanks for letting me know and sorry for the trouble!
from duffel-api-javascript.
Hi @randomprogramming, thanks for reaching out. Where did you learn "now you need to pass in a Place for the origin and destination objects"? Please let me know if you've seen that in our documentation so we can correct it. You will find that on the api reference of the create offer request endpoint slice's origin and destination must be a 3 letter string of the iata code for a city or airport:
The getting started guide seems to agree with that. Please do let me know if there's a mistake on the docs though, so we can correct asap. Thanks!
from duffel-api-javascript.
Maybe I am misunderstanding something, but:
Typescript gives me the error Type 'string' is not assignable to type 'Place'.ts(2322) typings.d.ts(1652, 13): The expected type comes from property 'origin' which is declared here on type 'Omit<OfferRequestSlice, "origin_type" | "destination_type">'
for all of these.
from duffel-api-javascript.
PR was just merged @randomprogramming. If you have any trouble please reach out!
from duffel-api-javascript.
Related Issues (20)
- `max_connections` is missing from type `CreateOfferRequest` HOT 1
- Should `OfferRequestSlice` `origin` and `destination` be type `Place`? HOT 2
- `OfferPassenger`` type` should be `DuffelPassengerType` not `string` HOT 1
- Missing key in OfferSliceSegment type HOT 2
- return_offers question HOT 2
- Undefined booking response, no errors returned HOT 18
- Selected service ID is not the valid one when reaching orders.create() HOT 3
- Reporting a vulnerability HOT 1
- Typescript Types are not aligned with API docs HOT 2
- Version 2.5.2 : Cannot find module 'Client' or its corresponding type declarations HOT 3
- Version 2.5.3: Cannot find module 'types' or its corresponding type declarations. HOT 4
- Type mismatch between documentation and Typescript types HOT 2
- import{URL as s,URLSearchParams as e}from"url" HOT 3
- Issue getting x-request-id
- `Airline` interface is missing `conditions_of_carriage_url` field HOT 1
- Missing `PassengerTitle` enum values HOT 1
- Question: What is the reason for different `origin`/`destination` types on `OfferSlice`/`OrderSlice` `Segment`s? HOT 5
- Wierd issue with Stays API HOT 3
- Multi-step search API does not return business or first class BA flights HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from duffel-api-javascript.