Coder Social home page Coder Social logo

Comments (4)

igorp1 avatar igorp1 commented on June 3, 2024 1

Ah I see, you are not misunderstanding it. The types for origin and destination are incorrect. I just opened a PR to correct that. Thanks for letting me know and sorry for the trouble!

from duffel-api-javascript.

igorp1 avatar igorp1 commented on June 3, 2024

Hi @randomprogramming, thanks for reaching out. Where did you learn "now you need to pass in a Place for the origin and destination objects"? Please let me know if you've seen that in our documentation so we can correct it. You will find that on the api reference of the create offer request endpoint slice's origin and destination must be a 3 letter string of the iata code for a city or airport:

Screenshot 2024-04-02 at 09 02 29

The getting started guide seems to agree with that. Please do let me know if there's a mistake on the docs though, so we can correct asap. Thanks!

from duffel-api-javascript.

randomprogramming avatar randomprogramming commented on June 3, 2024

Maybe I am misunderstanding something, but:

image

Typescript gives me the error Type 'string' is not assignable to type 'Place'.ts(2322) typings.d.ts(1652, 13): The expected type comes from property 'origin' which is declared here on type 'Omit<OfferRequestSlice, "origin_type" | "destination_type">' for all of these.

from duffel-api-javascript.

igorp1 avatar igorp1 commented on June 3, 2024

PR was just merged @randomprogramming. If you have any trouble please reach out!

from duffel-api-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.