Service Layer Authentication with Keycloak Not working about spring-addons

[ch4mpy]

Hi @v20gupta , may I ask you your procedure to create this issue? I thought I had set-up issues auto assignement, but apparently there is a path I missed.

Keycloak security does work on service layer. Unit tests would not pass otherwise.

Could you please provide me with a complete sample?
I suspect your test configuration to be broken. I suspect @ExtendWith(MockitoExtension.class) to be guilty. Maybe should you use SpringExtension for spring magic to happen?

[v20gupta]

Hi @ch4mpy , I was trying to unit test the keycloak security at the Service layer but my test case are passing even if I have not provide them the role.

@Service
public class AirportService {

	@Autowired
	private AirportDao airportDao;

	private final AirportMapper airportMapper = Mappers.getMapper( AirportMapper.class );

	@PreAuthorize(hasRole('std_airport_create'))
	public AirportRespDto createAirport(AirportReqDto airportReqDto) {
		Airport airport = airportMapper.airportDtoToAirport(airportReqDto);
		return airportMapper.airportToAirportDto(airportDao.save(airport));
	}
}

ServiceTesting:

@ExtendWith(SpringExtension.class)
@Import({AirportServiceTest.TestConfig.class})
class AirportServiceTest {

    @MockBean
    private AirportDao airportDao;

    @Autowired
    private AirportService airportService;

    private AirportReqDto airportReqDto1;
    private AirportReqDto airportReqDto2;
    private Airport airport1;
    private Airport airport2;
    private List<Airport> airportList;
    private List<AirportRespDto> airportRespList;
    private AirportMapper airportMapper;

    @BeforeEach
    public void setUp() {
        airportMapper = Mappers.getMapper( AirportMapper.class );
        airportList = new ArrayList<>();
        airportReqDto1 = AirportReqDto.builder().name("DelhiAirport").country("IND")
                .code("IND01").build();
        airportReqDto2 = AirportReqDto.builder().name("MumbaiAirport").country("IND")
                .code("IND01").build();

        airport1 = airportMapper.airportDtoToAirport(airportReqDto1);
        airport2 = airportMapper.airportDtoToAirport(airportReqDto2);
        airportList.addAll(Stream.of(airport1, airport2).collect(Collectors.toList()));
        airportRespList = airportMapper.airportsToAirportsDto(airportList);


    }
    @AfterEach
    public void tearDown() {
        airportReqDto1 = airportReqDto2 = null;
        airport1 = airport2 = null;
        airportList = null;
    }

    @Test
    @WithMockKeycloakAuth(authorities = "ROLE_std_airport_rea", id = @IdTokenClaims(sub = "abc"))
    public void createAirport() {
        Mockito.when(airportDao.save(any())).thenReturn(airport1);
        airportService.createAirport(airportReqDto1);
        verify(airportDao,times(1)).save(any());
    }

    @TestConfiguration(proxyBeanMethods = false)
    @Import({ AirportService.class })
    public static class TestConfig {
        @Bean
        public GrantedAuthoritiesMapper authoritiesMapper() {
            return new SimpleAuthorityMapper();
        }

    }

}

[ch4mpy]

• you haven't answered my 1st question (how have you proceeded to create this issue?)
• this is not a complete sample
• markdown is not used properly which makes your comments hardly readable (I edited it, but plz learn markdown)
• you have removed @EnableGlobalMethodSecurity(prePostEnabled = true) from your test conf. You shouldn't.

[v20gupta]

Thanks ch4mpy issue is resolved with adding @EnableGlobalMethodSecurity(prePostEnabled = true)