index.html template rendered as text when requesting "/" about caddy

[mholt]

I bet the bug is here:

reqExt := path.Ext(r.URL.Path)

for _, ext := range rule.Extensions {
    if reqExt == ext {

"/" doesn't have a ".html" extension, so the comparison fails and the template doesn't get executed. Should be a simple matter of checking if the path is a directory first, and if so, if an index file exists.

Although, more middlewares are going to run into this issue. Right now the list of index files is actually defined in the browse middleware which the core fileServer references. But maybe this isn't the best way to do it.

Perhaps each middleware that needs it could have an IndexFiles []string field that the application sets. (Of course, then we have to decide if an empty list defaults to index.html... etc.) To make this work well, I need to finish refactoring the config package and get those generator (New()) functions out of the middleware packages.

Okay - in summary: the simple fix is to just have the template middleware look for index.<extension> if the request is to a directory. That could hold us over for now, maybe?

[ciarand]

Yeah, that sounds reasonable. Though this was enough to hold me over for now:

rewrite / /index.html

[mholt]

@ciarand This fix will go out at the next release. Thank you again for your bug report!

[ciarand]

Sounds great, thanks @mholt!